Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use mangle cache invalidation for file purges #1029
If the PURGE_SERVER_TYPE is configured for mangle, use it for files purges instead of direct calls to Varnish. Also, don't fire off deletes to the files service for every image size as this slows down the request needlessly.
Please make sure the items below have been covered before requesting a review:
Steps to Test
sboisvert left a comment
I have a few questions that may be simple / irrelevant and are mostly based on the fact that I'm not confident in my ability to give proper feedback on this code based on my knowledge of the VIP Go platform.
mjangda left a comment
Overall looks good. Left some minor suggestions (e.g. to fix logs indexing) and a couple other small things.
The other we discussed and is worth noting is that in future PRs, we need to look into consolidating this code with the existing cache manager functionality to reduce the duplication. I'll track a separate issue for that.