Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Compat: Add fix for Contact Form 7 attachments #1189

Merged
merged 1 commit into from Apr 1, 2019

Conversation

@mjangda
Copy link
Member

mjangda commented Mar 16, 2019

The plugin attempts to write to a wp-content path which will fail. These files are transient and only meant to be included as attachment, so let's just tell CF7 to put them in /tmp/ which will work.

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • n/a This change has relevant unit tests (if applicable).
  • n/a This change has relevant documentation additions / updates (if applicable).

Steps to Test

  1. Check out PR.
  2. Install and activate Contact Form 7.
  3. Add a form with an file field.
  4. Something a form with a file and verify it's attached to the outgoing email.
The plugin attempts to write to a `wp-content` path which will fail. These files are transient and only meant to be included as attachment, so let's just tell CF7 to put them in `/tmp/` which will work.
Copy link
Member

jeremeylduvall left a comment

I tested this on a VIP Go site, and I can confirm that I was able to send contact form submissions with a form attachment. The file was attached to the resulting email.

I struggled mightily testing this locally (email server configs mainly), but I did test on a live Go site.

Not sure if that constitutes approval or not... 😄

@mjangda mjangda merged commit 984c37a into master Apr 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mjangda mjangda deleted the add/contact-form-7-upload-fix branch Apr 1, 2019
@mjangda

This comment has been minimized.

Copy link
Member Author

mjangda commented Apr 1, 2019

r135496-deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.