Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when user is logged out #221

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Log when user is logged out #221

merged 3 commits into from
Dec 21, 2018

Conversation

elazzabi
Copy link
Member

This displays a You are successfully logged out when user is logged out.

Steps to test

  1. get branch
  2. npm link
  3. vip logout

(if you're not logged in you'll be prompted to login, which is a bug)

fixes #129

mjangda
mjangda previously approved these changes Dec 20, 2018
Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor suggestion to add a period at the end.

src/bin/vip.js Outdated Show resolved Hide resolved
Co-Authored-By: elazzabi <elazzabi.ahmed@gmail.com>
@elazzabi elazzabi merged commit be65967 into master Dec 21, 2018
@elazzabi elazzabi deleted the add/logout-message branch December 21, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logout command gives no feedback
2 participants