Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All images uploaded to blog are immediately published to Mastodon without being added to a post #673

Closed
suramyatomar opened this issue Jan 23, 2024 · 6 comments · Fixed by #675
Assignees

Comments

@suramyatomar
Copy link

Quick summary

Whenever I upload an image to the Blog using the Upload files functionality in Wordpress Add Media page, the system automatically publishes it to Mastodon. It is happening to all images being added to the site even before they are inserted into a post.

Example: https://mastodon.social/@blog@www.suramya.com/111804854104552673

Steps to reproduce

  1. Start a new Blog post using the Classic Editor
  2. Click on 'Add Media' button
  3. Click on 'Upload Files' tab
  4. Upload an Image

What you expected to happen

Nothing should happen, because the image is not added to any post yet

What actually happened

The image is immediately published on Mastodon:
Screenshot_20240123_161858

Impact

All

Available workarounds?

No but the platform is still usable

Logs or notes

Self Hosted Wordpress version: 6.4.2
ActivityPub Version: 2.0.1

@suramyatomar suramyatomar added [Type] Bug Something isn't working Needs triage labels Jan 23, 2024
@janboddez
Copy link
Contributor

Do you perhaps have "media" enabled? Under wp-admin/options-general.php?page=activitypub&tab=settings

@suramyatomar
Copy link
Author

Yes, I did. Unchecking it seems to have resolved the issue. However, I have not changed the settings in a few months but didn't hit this issue till I upgraded to ver 2.x

@pfefferle
Copy link
Member

@suramyatomar yes, the earlier versions had a bug in the media federation and that was fixed in 2.0.0 :)

@suramyatomar
Copy link
Author

Ah ok.
I will recommend you add a small note to the settings page stating that enabling this value (media ) will post all images you upload to the site immediately to Mastodon.

@pfefferle
Copy link
Member

pfefferle commented Jan 24, 2024

The thing is, that this list is auto generated from the list of post types. I will see if there is a description I could use.

pfefferle added a commit that referenced this issue Jan 25, 2024
* Remove `page` from default types (fix #665)
* Add description to settings (fix #673)
pfefferle added a commit that referenced this issue Jan 25, 2024
* Improve post-type support

* Remove `page` from default types (fix #665)
* Add description to settings (fix #673)

* fix tests
@docpop
Copy link

docpop commented Jan 29, 2024

I had the same issue as Suramya and was surprised to see my images being published to my Mastodon feed. I have turned off "media" and "pages" from the "Supported post types", but I wanted to leave a suggestion. When I enabled those options, a year ago, I thought they enabled media to show up when I publish a post. I didn't expect them to auto-publish anytime I uploaded an image or new page. So I suggest changing the text from
Enable ActivityPub support for the following post types:
to
Automatically publish to the selected options to Mastodon
or something like that. You could also update the three options to say "New Posts, New Pages, New Media" or something like that to better convey that uploading an image to your dashboard will result in that media getting published to AP/Mastodon.

pfefferle added a commit that referenced this issue Jan 30, 2024
* change description
* add default description for Attachments

see #673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants