From 07311327e78655e0c29be54f5ca3a7ad4a6570b4 Mon Sep 17 00:00:00 2001 From: Matthias Pfefferle Date: Tue, 30 Sep 2025 13:14:11 +0200 Subject: [PATCH 1/5] Add external link icon to Jetpack reader feed link Updated the Jetpack integration to add the 'activitypub-external' class to the reader feed link, and added CSS to display a dashicon after external links. This visually indicates external links in the admin interface. --- assets/css/activitypub-admin.css | 8 ++++++++ integration/class-jetpack.php | 5 +++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/assets/css/activitypub-admin.css b/assets/css/activitypub-admin.css index 519d31090..11a9b132a 100644 --- a/assets/css/activitypub-admin.css +++ b/assets/css/activitypub-admin.css @@ -176,6 +176,14 @@ summary { transform: translateY(-30%) rotate(-135deg); } + +.activitypub-external:after { + font-family: dashicons; + vertical-align: baseline; + font-size: 0.9em; + content: " \f504"; +} + .activitypub-settings-accordion-trigger:active, .activitypub-settings-accordion-trigger:hover { background: #f6f7f7; diff --git a/integration/class-jetpack.php b/integration/class-jetpack.php index 2ed7f5940..4f1ba8e8c 100644 --- a/integration/class-jetpack.php +++ b/integration/class-jetpack.php @@ -10,6 +10,7 @@ use Activitypub\Collection\Followers; use Activitypub\Collection\Following; use Activitypub\Comment; +use Automattic\Jetpack\Connection\Manager; /** * Jetpack integration class. @@ -30,7 +31,7 @@ public static function init() { if ( ( \defined( 'IS_WPCOM' ) && IS_WPCOM ) || - ( \class_exists( '\Jetpack' ) && \Jetpack::is_connection_ready() ) + ( \class_exists( 'Automattic\Jetpack\Connection\Manager' ) && ( new Manager() )->is_user_connected() ) ) { \add_filter( 'activitypub_following_row_actions', array( self::class, 'add_reader_link' ), 10, 2 ); \add_filter( 'pre_option_activitypub_following_ui', array( self::class, 'pre_option_activitypub_following_ui' ) ); @@ -104,7 +105,7 @@ public static function add_reader_link( $actions, $item ) { return array_merge( array( 'reader' => sprintf( - '%s', + '%s', esc_url( $url ), esc_html__( 'View Feed', 'activitypub' ) ), From 6b9864ae8f37f7727c95533c0d6f8d8fdfc75d5e Mon Sep 17 00:00:00 2001 From: Matthias Pfefferle Date: Tue, 30 Sep 2025 13:20:55 +0200 Subject: [PATCH 2/5] Update Jetpack connection check in integration Replaces the use of Automattic\Jetpack\Connection\Manager for checking user connection with Jetpack::is_connection_ready(). This simplifies the connection check and removes an unnecessary use statement. --- integration/class-jetpack.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/integration/class-jetpack.php b/integration/class-jetpack.php index 4f1ba8e8c..f17800ef0 100644 --- a/integration/class-jetpack.php +++ b/integration/class-jetpack.php @@ -10,7 +10,6 @@ use Activitypub\Collection\Followers; use Activitypub\Collection\Following; use Activitypub\Comment; -use Automattic\Jetpack\Connection\Manager; /** * Jetpack integration class. @@ -31,7 +30,7 @@ public static function init() { if ( ( \defined( 'IS_WPCOM' ) && IS_WPCOM ) || - ( \class_exists( 'Automattic\Jetpack\Connection\Manager' ) && ( new Manager() )->is_user_connected() ) + ( \class_exists( '\Jetpack' ) && \Jetpack::is_connection_ready() ) ) { \add_filter( 'activitypub_following_row_actions', array( self::class, 'add_reader_link' ), 10, 2 ); \add_filter( 'pre_option_activitypub_following_ui', array( self::class, 'pre_option_activitypub_following_ui' ) ); From eb900bd72564eb61a5201d4a42e3a89caa11f3a5 Mon Sep 17 00:00:00 2001 From: Matthias Pfefferle Date: Tue, 30 Sep 2025 13:24:34 +0200 Subject: [PATCH 3/5] Add aria-label to Reader link for accessibility The Reader link in the Jetpack integration now includes an aria-label attribute to improve accessibility for screen readers. --- integration/class-jetpack.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/integration/class-jetpack.php b/integration/class-jetpack.php index f17800ef0..150988d24 100644 --- a/integration/class-jetpack.php +++ b/integration/class-jetpack.php @@ -104,8 +104,9 @@ public static function add_reader_link( $actions, $item ) { return array_merge( array( 'reader' => sprintf( - '%s', + '%s', esc_url( $url ), + esc_html__( 'View feed in the WordPress.com Reader', 'activitypub' ), esc_html__( 'View Feed', 'activitypub' ) ), ), From 70ebb2193cb3834a1539969ebbe881eb9b90807d Mon Sep 17 00:00:00 2001 From: Matthias Pfefferle Date: Tue, 30 Sep 2025 13:31:22 +0200 Subject: [PATCH 4/5] Update external link icon and accessibility in Jetpack integration Removes the CSS-based external link icon and updates the Jetpack integration to use a Dashicons icon within the link markup. Improves accessibility by adding screen reader text indicating the link opens in a new tab. --- assets/css/activitypub-admin.css | 8 -------- integration/class-jetpack.php | 7 ++++--- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/assets/css/activitypub-admin.css b/assets/css/activitypub-admin.css index 11a9b132a..519d31090 100644 --- a/assets/css/activitypub-admin.css +++ b/assets/css/activitypub-admin.css @@ -176,14 +176,6 @@ summary { transform: translateY(-30%) rotate(-135deg); } - -.activitypub-external:after { - font-family: dashicons; - vertical-align: baseline; - font-size: 0.9em; - content: " \f504"; -} - .activitypub-settings-accordion-trigger:active, .activitypub-settings-accordion-trigger:hover { background: #f6f7f7; diff --git a/integration/class-jetpack.php b/integration/class-jetpack.php index 150988d24..8a9d254a2 100644 --- a/integration/class-jetpack.php +++ b/integration/class-jetpack.php @@ -104,10 +104,11 @@ public static function add_reader_link( $actions, $item ) { return array_merge( array( 'reader' => sprintf( - '%s', + '%2$s %3$s', esc_url( $url ), - esc_html__( 'View feed in the WordPress.com Reader', 'activitypub' ), - esc_html__( 'View Feed', 'activitypub' ) + esc_html__( 'View Feed', 'activitypub' ), + /* translators: Hidden accessibility text. */ + esc_html__( '(opens in a new tab)', 'activitypub' ) ), ), $actions From f80ae3b305c5a9b542fb8c6cdb8872a0ff5c7393 Mon Sep 17 00:00:00 2001 From: Matthias Pfefferle Date: Tue, 30 Sep 2025 15:58:25 +0200 Subject: [PATCH 5/5] Adjust dashicon styles in followings table Set font size and line height for dashicons within the followings table to improve visual consistency. --- assets/css/activitypub-admin.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/assets/css/activitypub-admin.css b/assets/css/activitypub-admin.css index 519d31090..7a92bdaa8 100644 --- a/assets/css/activitypub-admin.css +++ b/assets/css/activitypub-admin.css @@ -176,6 +176,11 @@ summary { transform: translateY(-30%) rotate(-135deg); } +table.followings .dashicons { + font-size: 1em; + line-height: 1.7; +} + .activitypub-settings-accordion-trigger:active, .activitypub-settings-accordion-trigger:hover { background: #f6f7f7;