add path to route #438
Merged
add path to route #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edent can you verify that this PR fixes your issue? |
|
🙌🙌🙌🙌🙌 I can now follow Will check in an hour or so if it pushes out the scheduled post to subscriber. |
|
@mattwiebe @ebinnion might this break something on WP.com?
|
mattwiebe
approved these changes
Sep 20, 2023
| $path = wp_parse_url( get_home_url(), PHP_URL_PATH ); | ||
| $path = trim( $path, '/' ); | ||
|
|
||
| if ( $path ) { |
There was a problem hiding this comment.
I'd maybe check instead for ! empty( $path ) here instead, although this would probably be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #421
Proposed changes:
Other information:
Testing instructions: