Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 23, 2024

When using blocks like Followers and Follow Me, previously, it reported that it would be empty in non-author contexts in the editor. In realty, this is only true if the blog-level profile is not enabled.

Proposed changes:

  • Conditionally include the empty disclaimer to only when the site profile is disabled.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • With AP set to only author profiles, attempt to add a Follow Me block set to Dynamic User. See the fallback text that mentions it'll be empty.
  • With AP set to have the blog and author profiles, do the same as above. See the fallback text without the empty disclaimer.

@pfefferle pfefferle requested a review from mattwiebe October 23, 2024 19:29
@mattwiebe
Copy link
Contributor

@kraftbj thanks so much for the PR! I updated it a bit to make proper use of i18n, because apparently adding a /* translators */ comment wasn't enough 🤦

Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mattwiebe mattwiebe merged commit 62281bf into trunk Oct 23, 2024
21 checks passed
@mattwiebe mattwiebe deleted the fix/non-empty-when-blog-enabled branch October 23, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants