Add Swift Pagination #380
Merged
Add Swift Pagination #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
add/swift-pagination
branch
from
b9cfa90 to
063fb14
Compare
crazytonyli
approved these changes
Nov 13, 2024
| while let nextPageParams = workingResponse.nextPageParams { | ||
| workingResponse = try await self.listWithEditContext(params: nextPageParams) | ||
| allObjects.append(contentsOf: workingResponse.data) | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick: using do-while to avoid duplicating listWithEditContext and appending(contentsOf:...) calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic Swift auto-pagination based on #375 and #376.
To Test: