Upgrade project to Swift 6 #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
upgrade/to-swift-6
branch
from
dc1d18b to
dbfb28c
Compare
jkmassel
commented
Nov 14, 2024
|
|
||
| #if !os(Linux) | ||
| // Skip on Linux, because `XCTExpectFailure` is unavailable on Linux | ||
| func testTimeout() async throws { |
Contributor
Author
There was a problem hiding this comment.
This test was in the project twice, so I removed it here
jkmassel
commented
Nov 14, 2024
| private let missingStub: Result<WpNetworkResponse, Error>? | ||
|
|
||
| var missingStub: Result<WpNetworkResponse, Error>? | ||
| init(stubs: [Stub] = [], missingStub: Result<WpNetworkResponse, Error>? = nil) { |
Contributor
Author
There was a problem hiding this comment.
Because SafeRequestExecutor needs to be Sendable, we need our stubs to be too.
The easiest way to do that is to just make them immutable, which doesn't change the code all that much
jkmassel
force-pushed
the
upgrade/to-swift-6
branch
from
dbfb28c to
3b3d581
Compare
Now all tests can run on Linux!
Foundation is now the same across all platforms, so we can use `URLSession.data(for:) async throws` on Linux now
jkmassel
force-pushed
the
upgrade/to-swift-6
branch
from
3b3d581 to
5bd7068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the project to Swift 6, which brings a few benefits:
Foundationis now the same across platforms.swift-testing, which makes our test suite a lot simpler