Skip to content

People: Scrolling through team list causes an unresponsive page #23937

Closed

Description

Edit by @gwwar: I'd recommend for any content we need to manage that we have a simple pager instead of an infinite list. Infinite lists are usually better for consuming content.

When scrolling through the people list (at /people/team/:site), I somehow triggered an infinite loop where the InfiniteList component keeps trying to update state. I end up with an unresponsive page, and this error:

Uncaught Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops. The above error occurred in the <InfiniteList> component

screen shot 2018-04-05 at 11 03 30 am

I discovered this on a site with 22 people, replicated on a site with 734 users, but could not replicate on a site with 2 users (there was no scroll).

This is on Mac OS/Chrome.


Update by @mattsherman:

As mentioned in #25609, this also happens in the /people/followers/{site} section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions