Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are lots of primary actions on the Store on-boarding task list #33262

Closed
jameskoster opened this issue May 23, 2019 · 1 comment · Fixed by #33825
Closed

There are lots of primary actions on the Store on-boarding task list #33262

jameskoster opened this issue May 23, 2019 · 1 comment · Fixed by #33825

Comments

@jameskoster
Copy link
Contributor

Ideally there should only be a single primary action per page. Instead we see this, which is kind of overwhelming:

1

Possible solutions:

Short term: Make only the "next" task primary.

Long term: Employ a pattern like this which is Muriel friendly.

@MichaelArestad
Copy link
Contributor

I created two pull requests to address this. Neither is the ideal solution, but are an improvement.

The first is quite nuclear: #33820

It removes all the primary buttons on any checklist. This could probably resolve this issue across the board for the Checklist pattern. I think another non-bottle issues could be created to make the checklist function in a linear fashion where only the next suggested step's button is primary.

The second is more surgical: #33825

It just changes the buttons on the Store list to be secondary instead of primary.

@jameskoster @cburton4 What do you think?

@MichaelArestad MichaelArestad moved this from Assigned to In Progress in All Design Meetup - Fixing the Flows Jun 11, 2019
@MichaelArestad MichaelArestad moved this from In Progress to Needs Review in All Design Meetup - Fixing the Flows Jun 11, 2019
@scruffian scruffian moved this from Needs Review to Reviewed in All Design Meetup - Fixing the Flows Jun 11, 2019
@scruffian scruffian moved this from Reviewed to Needs Review in All Design Meetup - Fixing the Flows Jun 11, 2019
All Design Meetup - Fixing the Flows automation moved this from Needs Review to Done Jun 11, 2019
@sixhours sixhours added this to New in Fixing the Flows via automation Jun 17, 2019
@sixhours sixhours moved this from New to Done in Fixing the Flows Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2 participants