New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Editor: Inline Edit Button #8306

Closed
gwwar opened this Issue Sep 28, 2016 · 6 comments

Comments

Projects
5 participants
@gwwar
Member

gwwar commented Sep 28, 2016

Clicking on an image in the post editor brings up an in-context menu. Let's add an edit icon to that menu. When we click on that the inline edit button will bring up the details view of that image.

screen shot 2016-09-28 at 4 02 04 pm

Media Modal Details View:
screen shot 2016-09-28 at 3 54 13 pm

@gwwar gwwar added this to the Image Editor milestone Sep 28, 2016

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Sep 29, 2016

Member

Related: #307, #2085, 10349-gh-calypso-pre-oss

Design-wise, there's been many discussions in the past about whether it should open the full details view or some custom view. If opening as the full details view, we should consider the effects of all possible actions (e.g. delete? return to library view [maybe replaces]?).

Member

aduth commented Sep 29, 2016

Related: #307, #2085, 10349-gh-calypso-pre-oss

Design-wise, there's been many discussions in the past about whether it should open the full details view or some custom view. If opening as the full details view, we should consider the effects of all possible actions (e.g. delete? return to library view [maybe replaces]?).

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Sep 29, 2016

Member

This kinda feels like a duplicate of #307

Member

aduth commented Sep 29, 2016

This kinda feels like a duplicate of #307

@gwwar

This comment has been minimized.

Show comment
Hide comment
@gwwar

gwwar Sep 30, 2016

Member

Thanks @aduth for the links! I can close this in favor of #307

Member

gwwar commented Sep 30, 2016

Thanks @aduth for the links! I can close this in favor of #307

@gwwar gwwar closed this Sep 30, 2016

@rralian

This comment has been minimized.

Show comment
Hide comment
@rralian

rralian Feb 15, 2017

Contributor

#307 is more broad and includes expanding the image modal to include other options. I would treat these separately and prioritize this one as the top priority for improving image-editing flow. It's most important that you can get to the existing image editor controls from an inline image.

Contributor

rralian commented Feb 15, 2017

#307 is more broad and includes expanding the image modal to include other options. I would treat these separately and prioritize this one as the top priority for improving image-editing flow. It's most important that you can get to the existing image editor controls from an inline image.

@rralian rralian reopened this Feb 15, 2017

@rralian rralian added this to TODO in Image Editor v2 Feb 15, 2017

@rralian

This comment has been minimized.

Show comment
Hide comment
@rralian

rralian Feb 15, 2017

Contributor

I'm setting the priority of this as a blocker for the image-editor v2 flow. IMHO it's the main point of the project and should be the first thing we do.

Contributor

rralian commented Feb 15, 2017

I'm setting the priority of this as a blocker for the image-editor v2 flow. IMHO it's the main point of the project and should be the first thing we do.

@jblz

This comment has been minimized.

Show comment
Hide comment
@jblz

jblz May 22, 2017

Member

Fixed via merging #14143

Member

jblz commented May 22, 2017

Fixed via merging #14143

@jblz jblz closed this May 22, 2017

@jblz jblz moved this from In Progress to Done in Image Editor v2 May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment