Imports: Remove routing for onboarding flow query param#101605
Merged
Imports: Remove routing for onboarding flow query param#101605
Conversation
sixhours
added
Import
[Feature] Importing & Exporting
matticbot
added
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~73 bytes removed 📉 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3841 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~500 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Contributor
andres-blanco
left a comment
andres-blanco
left a comment
There was a problem hiding this comment.
The importers screen shows up fine, but there's something broken in the CSS when selecting the WordPress option.
Screen.Recording.2025-03-19.at.3.45.01.PM.mov
daledupreez
reviewed
Mar 20, 2025
Contributor
daledupreez
left a comment
daledupreez
left a comment
There was a problem hiding this comment.
It also looks like the importerList function was added in #85830 - we should also clean that up.
8 tasks
Contributor
It will probably get fixed by a rebase. At least that's what happened here |
sixhours
force-pushed
the
remove/unused-import-flow
branch
from
5817f5f to
aadafac
Compare
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Contributor
Author
|
I've rebased! @andres-blanco I couldn't play the video clip and I'm not seeing anything weird in the CSS when I click on the WordPress option. |
andres-blanco
approved these changes
Mar 25, 2025
github-actions
bot
removed
the
[Status] Needs Review
This was referenced Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #101382
Proposed Changes
Visual
Before
After
Why are these changes being made?
Testing Instructions
Pre-merge Checklist