Skip to content

Comments

A4A > WooPayments: Fix empty state link color#101761

Merged
yashwin merged 1 commit intotrunkfrom
fix/a4a/woopayments/empty-state-link-color
Mar 24, 2025
Merged

A4A > WooPayments: Fix empty state link color#101761
yashwin merged 1 commit intotrunkfrom
fix/a4a/woopayments/empty-state-link-color

Conversation

@yashwin
Copy link
Contributor

@yashwin yashwin commented Mar 24, 2025

Proposed Changes

  • Resolves an issue with the empty state link color when it is active.

Testing Instructions

  • Open the A4A live link
  • Go to WooPayments: Dashboard > Verify the link color stays intact when it is active in the empty state view.

Open the dev too > Select the element > Right click > Force state > Select :active

Screenshot 2025-03-24 at 8 56 38 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team March 24, 2025 03:34
@yashwin yashwin self-assigned this Mar 24, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 24, 2025
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/woopayments/empty-state-link-color on your sandbox.

@yashwin yashwin merged commit 6d78536 into trunk Mar 24, 2025
16 of 18 checks passed
@yashwin yashwin deleted the fix/a4a/woopayments/empty-state-link-color branch March 24, 2025 03:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants