BT followup: Add BusinessCardBadge and tax label adjustments to Billing History receipt#101863
BT followup: Add BusinessCardBadge and tax label adjustments to Billing History receipt#101863jjchrisdiehl wants to merge 26 commits intotrunkfrom
Conversation
The cancel purchase link was hidden for non-plans in #101493. If this is a necessary as part of the self-service plan downgrades feature, then the logic will need to be updated to include a check for the `plans/self-service-downgrade` feature flag.
* Move date range header outside of card * update styling a little * adds percentage bar measurement rows * fix spacing on horizontal rows + tidy up * Indent the horizontal bar span text * adds hover styling to rows * align grid headings and styling * update header cell top padding * Update client/my-sites/stats/videopress-stats-module/style.scss --------- Co-authored-by: Jasper Kang <jasper.kang@automattic.com>
Site slug can be incorrect for the sites where WordPress lives in a subdirectory. Using siteId generates a correct checkout URL regardless of the environment
* Gravatar: Handle Gravatar quick editor sign-in case * Add more props and make the tracking event not working * Rename is_start_view to is_initial_view * Update titles --------- Co-authored-by: Welly Shen <welly.shen@automattic.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Kosta <heavyweight@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Kosta <heavyweight@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
#101739) * Use the new container * Use Step.Heading component for domain transfer step * Adjust "transfer-or-connect" styling * Fix transfer-or-connect layout on mobile --------- Co-authored-by: Philip Jackson <p-jackson@live.com>
* remove query date filter from following * remove test changes for following date cutoff * remove following stream__caught-up component * update empty content text for following feed * fix unit tests
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~271 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2676 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~844 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a trunk merge or rebase and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
|
This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR. |
This PR contains the code that adds a BusinessCardBadge to Billing History, the badge was first introduced in #101353. There is also code that adjusts the label for the receipt tax line item to better denote what the tax rate change is for (OH and CT state business tax).
The Billing History code was moved as I'll need to provide information from the
me/billing-historyendpoint to handle:Since this relies on a backend change, I figured its better to just break it off from the other changes to unblock them.
Related to #101353 and https://github.com/Automattic/payments-shilling/issues/3239
Proposed Changes
Add a Business Card badge to Payment Method line in Billing History > View Receipt
cc_is_for_businessvalue that is passed from the/me/billing-historyendpoint in (coming soon)is_for_businessvalue is saved on the tax_location of thestored_details, I decided to drop this value into the billing-history through the CC values rather than settingtax_is_for_businessinme/billing-history's response. We can derive that the tax applied here is for business from the stored details, since currently there is no way to separate these two values (i.e. a receipt with a business card that doesn't have a tax using thefor_businessvalue)Adjust the receipt tax line item label to note the OH or CT business tax applied
Testing Instructions
Test the business card badge
is for businesstransaction on it (you could also just sandbox the API and complete a checkout with a Stripe test card, just make sure to set your country to US, and postal code to OH or CT43010, then check off theis this purchase for business?checkbox in Billing Information during Checkout)me > Purchases > Billing Historyand from the actions column click on View ReceiptTest the tax label adjustment