Skip to content

Comments

Self Service Downgrade: Disable downgrade buttons on plans grid#101888

Merged
ddc22 merged 6 commits intotrunkfrom
fix/hide-downgrade-button-on-plans-grid
Mar 27, 2025
Merged

Self Service Downgrade: Disable downgrade buttons on plans grid#101888
ddc22 merged 6 commits intotrunkfrom
fix/hide-downgrade-button-on-plans-grid

Conversation

@ddc22
Copy link
Contributor

@ddc22 ddc22 commented Mar 26, 2025

Proposed Changes

  • Disabled the downgrade button from the plans grid
alt

Why are these changes being made?

  • The downgrade button has been moved to the purchases page so this button needs to be disabled.

Testing Instructions

  • Purchase a higher tier plans and make sure all buttons below it are disabled and shows the Requires downgrade label

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

@ddc22 ddc22 requested a review from claudiucelfilip March 26, 2025 11:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~45 bytes added 📈 [gzipped])

Details
name                      parsed_size           gzip_size
plugins                        +115 B  (+0.0%)      +45 B  (+0.0%)
plans                          +115 B  (+0.0%)      +45 B  (+0.0%)
jetpack-app                    +115 B  (+0.0%)      +45 B  (+0.0%)
async-step-unified-plans       +115 B  (+0.0%)      +45 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~45 bytes added 📈 [gzipped])

Details
name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +115 B  (+0.0%)      +45 B  (+0.0%)
async-load-signup-steps-plans                         +115 B  (+0.0%)      +45 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hide-downgrade-button-on-plans-grid on your sandbox.

Comment on lines 426 to 432
return {
primary: {
callback: () => {},
text: '',
status: 'hidden',
},
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should move it behind the plans/self-service-downgrade feature flag.

@claudiucelfilip claudiucelfilip changed the title Hide downgrade button on plans grid Self Service Downgrade: Disable downgrade buttons on plans grid Mar 27, 2025
@claudiucelfilip claudiucelfilip marked this pull request as ready for review March 27, 2025 10:28
@claudiucelfilip claudiucelfilip requested a review from a team as a code owner March 27, 2025 10:28
Copy link
Contributor

@claudiucelfilip claudiucelfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasmussen
Copy link
Member

I'm personally not entirely enthusiastic about this option compared to the other one, so just want to note that, with the full context noted in p58i-kuF-p2#comment-67415

That being said, if you're all willing to keep following up on this, I do appreciate you following up on at least one of the options outlined. 👍 👍

@dlind1 dlind1 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 27, 2025
@ddc22 ddc22 merged commit ac50eb5 into trunk Mar 27, 2025
20 of 21 checks passed
@ddc22 ddc22 deleted the fix/hide-downgrade-button-on-plans-grid branch March 27, 2025 14:48
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 27, 2025
@a8ci18n
Copy link

a8ci18n commented Mar 27, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17318197

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @ddc22 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 27, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants