Signup: Implement `FormTextInputWithAction` in Survey Other substep #10404

Merged
merged 1 commit into from Jan 6, 2017

Projects

None yet

4 participants

@bisko
Contributor
bisko commented Jan 4, 2017 edited

The FormTextInputWithAction component ( Automattic/wp-calypso#8638 ) was created as a spinoff of the Other sub-step and now we're implementing it back into the step.

Updated the component a bit, because it didn't properly pass the value to the parent.

To test:

  1. Checkout branch or use Calypso.live link
  2. Start Signup at /start/surveystep to access the Survey step, since it's not available in the main flow at the moment
  3. Choose Other
  4. Type text, verify there are no JS errors.
  5. Submit the Survey step
  6. Verify that the dependency store has the correct text ( in the Redux store -> IndexedDB -> Signup -> dependencyStore ) value and the correct parameters have been set to the analytics events
  7. Verify no JS errors are shown in the console
  8. Finish Signup
  9. Verify the proper Verticals have been sent to Site creation

Bonus steps: Verify if .blog domains are suggested properly for the respective verticals.

cc @michaeldcain @coreh

@bisko bisko Signup: Implement `FormTextInputWithAction` in Survey Other substep
The `FormTextInputWithAction` component was created as a spinoff of the Other substep and now we're implementing it back into the step.

Updated the component a bit, because it didn't properly pass the value to the parent.
67b53f3
@bisko bisko self-assigned this Jan 4, 2017
@bisko bisko requested review from coreh and michaeldcain Jan 4, 2017
@michaeldcain

LGTM 👍

@bisko bisko merged commit ead4e83 into master Jan 6, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/i18n 0 new strings. ¡Ándale!
@bisko bisko deleted the fix/signup-update-survey-step-other-component branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment