Guided Tours: Fix Site Title Tour step not showing #10521

merged 1 commit into from Jan 11, 2017


None yet

4 participants

marekhrabe commented Jan 10, 2017 edited

This PR fixes Site Title Tour that didn't show one of its steps when it was freshly loaded (without the browser cache).

The problem was that the settings section was loading some async data and didn’t show the UI before the data loaded (meaning we had no target for step yet), but we didn’t rerender guided our tours when the data loaded, as we only look for limited action set in action log.

This adds SITE_SETTINGS_RECEIVE to actionLog.

To test:

  1. Disable browser cache
  2. Load http://calypso.localhost:3000/stats/_slug_?tour=siteTitle
  3. Let the tour start and click Next on the first step
  4. Go to your dev tools (Network tab) and turn on network throttling. Regular 3G worked pretty well
  5. Quickly click Settings menu item (don't hover it for too long, because the settings section might get preloaded)
  6. Don't do anything and just let it load
  7. You should see a tour step once the site title input is visible

If you test the same scenario in production, the step won't show until you do some kind of interaction (like scrolling).

mcsf approved these changes Jan 10, 2017 View changes
lsinger commented Jan 11, 2017

LGTM! :shipit:

@marekhrabe marekhrabe merged commit a718e1c into master Jan 11, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
@marekhrabe marekhrabe deleted the fix/site-title-input-step branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment