Stats: Remove unused stats-lists from site page. #10629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyc
added
Stats
youknowriad
approved these changes
Jan 16, 2017
youknowriad
added
[Status] Ready to Merge
and removed
[Status] Needs Review
timmyc
force-pushed
the
update/stats/remove-unused-lists
branch
from
b1994d6
to
8ce6d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when I read old code and have moments of "what the .... is that doing there?" - and this is one of them 馃挴
Stroll Down Memory Lane
At one time, prior to the Insights tab being launched, Tags, Comments, and Followers ( aka
nonPeriodicModules) lived on the Stats Day/Week/Month/Year pages. When Insights was launched, these modules were still shown on the Stats "period" pages for a while - I believe while A/B testing - but have long since permanently moved to Insights.But yet these lines of code have remained well after their welcome was long gone... almost like a random friend from college who wanted to crash at your house for a week, but is still there two months later.
Well, old stats lists, it is time you are shown to the door... and take your five un-needed network requests with you.
To Test