New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LikeButton: fix i18n context #11689

Merged
merged 2 commits into from Mar 1, 2017

Conversation

Projects
None yet
4 participants
@mcsf
Copy link
Member

mcsf commented Mar 1, 2017

The pt-pt translation of the Reader has been broken for a while, and I suspect this affects other locales:

Before

screen shot 2017-03-01 at 21 31 56

The above reads: "1 comment" (correct) and "1 [the verb "to like", infinitive form]" (incorrect). This is because in English both forms are labeled Like while they are separate terms with very different function.

After

screen shot 2017-03-01 at 21 32 06

^ The above is a reflection of the lack of translated strings in local Calypso, but the string should now become translatable.

Testing

  • In either the Reader or in /posts's comment view, look for posts with exactly one like.
  • In English, everything should behave and look the same as without the patch.
  • With other locales, YMMV, but make sure that the translation of "1 Like" is sane.
@matticbot

This comment has been minimized.

@matticbot matticbot added the [Size] S label Mar 1, 2017

@@ -58,7 +58,10 @@ const LikeButton = React.createClass( {
'has-count': showLikeCount,

This comment has been minimized.

@a8ci18n

a8ci18n Mar 1, 2017

Hi! I've found a possible matching string that has already been translated 30 times:
translate( 'Like', { context: 'verb: imperative'} ) ES Score: 11
See 2 additional suggestions in the PR translation status page

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

ℹ️ This string already exists with the following contexts:

  • null (no context)
  • comment

Would it make sense to reuse one of the above?

@blowery

blowery approved these changes Mar 1, 2017

Copy link
Contributor

blowery left a comment

LGTM

@blowery

This comment has been minimized.

Copy link
Contributor

blowery commented Mar 1, 2017

Thanks @mcsf! I'm sad the translation was busted all this time.

Any others that stand out?

@mcsf

This comment has been minimized.

Copy link
Member

mcsf commented Mar 1, 2017

Thanks for the quick review, @blowery!

Any others that stand out?

Not that I remember, but I'll keep an eye out. I believe this was intro'd in f40617e (cc @shaunandrews).

@mcsf mcsf merged commit 06b6f1f into master Mar 1, 2017

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
ci/i18n Total: 1 string. Everything already translated!
Details

@mcsf mcsf deleted the fix/i18n-like-button-context branch Mar 1, 2017

retrofox added a commit that referenced this pull request Mar 4, 2017

LikeButton: fix i18n context (#11689)
* LikeButton: fix i18n context

* Follow the little bot's suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment