New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated segmented control item to show data-e2e attribute #13853

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
4 participants
@alisterscott
Contributor

alisterscott commented May 10, 2017

Adds a data-e2e-value attribute to segmented control items. This is for automated e2e testing purposes.

To test

Open: https://calypso.live/themes/?branch=add/data-e2e-value-for-segmented-control-items
Verify that the 'All', 'Free' and 'Premium' all have data-e2e-value attributes in the DOM.

This is to address: Automattic/wp-e2e-tests#152

@matticbot matticbot added the [Size] S label May 10, 2017

@matticbot

This comment has been minimized.

@markryall

This looks good :shipit:

@alisterscott alisterscott merged commit f42bbf6 into master May 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/i18n 0 new strings. ¡Ándale!
Details

@alisterscott alisterscott deleted the add/data-e2e-value-for-segmented-control-items branch May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment