New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added context to domain upgrade renewal and expiration strings #15656

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
5 participants
@iamgabrielma
Contributor

iamgabrielma commented Jun 29, 2017

Fixes #248 adding context for the translators when translating some strings. Followed the examples here: https://github.com/Automattic/i18n-calypso#more-translate-examples . With these 3 files we should cover all the cases on domain upgrade renewal / expiration.

I'm not quite sure how to test this locally, as the context will show up on http://translate.wordpress.com/ once is live. Any feedback is appreciated.

@matticbot

This comment has been minimized.

Show comment
Hide comment

matticbot commented Jun 29, 2017

@aidvu

The linter is probably going to complain. Also, not sure if comment or context: https://github.com/Automattic/i18n-calypso#options

@iamgabrielma

This comment has been minimized.

Show comment
Hide comment
@iamgabrielma

iamgabrielma Jun 29, 2017

Contributor

Also, not sure if comment or context: https://github.com/Automattic/i18n-calypso#options

I'd say is comment because there is not a need for an alternative translation depending on the context, just tells the translators that the date isn't included in the string because is in a different place. Maybe @rachelmcr can clarify this point.

Contributor

iamgabrielma commented Jun 29, 2017

Also, not sure if comment or context: https://github.com/Automattic/i18n-calypso#options

I'd say is comment because there is not a need for an alternative translation depending on the context, just tells the translators that the date isn't included in the string because is in a different place. Maybe @rachelmcr can clarify this point.

@rachelmcr

This comment has been minimized.

Show comment
Hide comment
@rachelmcr

rachelmcr Jun 29, 2017

Member

As @yoavf noted on the issue, this should be added a translator comment, not context, to preserve the existing translations.

Member

rachelmcr commented Jun 29, 2017

As @yoavf noted on the issue, this should be added a translator comment, not context, to preserve the existing translations.

@yoavf

This comment has been minimized.

Show comment
Hide comment
@yoavf

yoavf Jun 29, 2017

Member

I'm not quite sure how to test this locally

You can run make translate and look at the calypso-strings.pot file that will be generated.

Member

yoavf commented Jun 29, 2017

I'm not quite sure how to test this locally

You can run make translate and look at the calypso-strings.pot file that will be generated.

@matticbot matticbot added [Size] XL and removed [Size] S labels Jun 29, 2017

@aidvu

This comment has been minimized.

Show comment
Hide comment
@aidvu

aidvu Jun 29, 2017

Contributor

The rebase probably didn't go as expected. :)

Contributor

aidvu commented Jun 29, 2017

The rebase probably didn't go as expected. :)

Gabriel Maldonado Almendra Gabriel Maldonado Almendra

@matticbot matticbot added [Size] S and removed [Size] XL labels Jun 30, 2017

@iamgabrielma

This comment has been minimized.

Show comment
Hide comment
@iamgabrielma

iamgabrielma Jun 30, 2017

Contributor

The rebase probably didn't go as expected. :)

Definitely, seems that when I tried to fix the ESLint errors, I rebased wrongly and created a divergent branch, that’s why every time I tried to rebase again didn’t work. I've created a new clean branch from the latest master and overwritten this one with the changes via push --force. I hope now works alright now! Thanks for the tips @aidvu

Contributor

iamgabrielma commented Jun 30, 2017

The rebase probably didn't go as expected. :)

Definitely, seems that when I tried to fix the ESLint errors, I rebased wrongly and created a divergent branch, that’s why every time I tried to rebase again didn’t work. I've created a new clean branch from the latest master and overwritten this one with the changes via push --force. I hope now works alright now! Thanks for the tips @aidvu

@aidvu

aidvu approved these changes Jun 30, 2017

LGTM

@iamgabrielma iamgabrielma merged commit 049400b into master Jun 30, 2017

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
ci/i18n Total: 5 strings. Everything already translated!
Details

@klimeryk klimeryk deleted the fix/248 branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment