New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added context to domain upgrade renewal and expiration strings #15656
Conversation
Test live: https://calypso.live/?branch=fix/248 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is probably going to complain. Also, not sure if comment or context: https://github.com/Automattic/i18n-calypso#options
@@ -25,7 +25,7 @@ const MappedDomain = React.createClass( { | |||
|
|||
if ( domain.isAutoRenewing ) { | |||
return ( | |||
<Property label={ translate( 'Mapping renews on' ) }> | |||
<Property label={ translate( 'Mapping renews on', {comment: 'The corresponding date is in a different cell in the UI, the date is not included within the translated string'} ) }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces after and before curly braces. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will do! :D
I'd say is |
As @yoavf noted on the issue, this should be added a translator comment, not context, to preserve the existing translations. |
You can run |
The rebase probably didn't go as expected. :) |
… making it diverge
Definitely, seems that when I tried to fix the ESLint errors, I rebased wrongly and created a divergent branch, that’s why every time I tried to rebase again didn’t work. I've created a new clean branch from the latest master and overwritten this one with the changes via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #248 adding context for the translators when translating some strings. Followed the examples here: https://github.com/Automattic/i18n-calypso#more-translate-examples . With these 3 files we should cover all the cases on domain upgrade renewal / expiration.
I'm not quite sure how to test this locally, as the context will show up on http://translate.wordpress.com/ once is live. Any feedback is appreciated.