New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Settings: Moves Site Address up to Site Profile card #1682

Merged
merged 1 commit into from Dec 17, 2015

Conversation

Projects
None yet
5 participants
@alternatekev
Contributor

alternatekev commented Dec 16, 2015

Currently, Site Address is a little buried, and kind of in the wrong place. There's no real reason it should be grouped with Visibility instead of Site Profile:

screen shot 2015-12-16 at 9 29 58 am

This PR cleans up the whole Site Profile card and moves Site Address to a CompactCard-looking area (replicated with the component's current use of <fieldset />):

screen shot 2015-12-16 at 9 32 53 am

pinging @mikeshelton1503 @rickybanister

@rickybanister

This comment has been minimized.

Show comment
Hide comment
@rickybanister

rickybanister Dec 16, 2015

Member

This gave me an idea—I think the address should be the second item, right below the title. That mimics the Site card.

We should then put the blavatar interface to the left of those two fields and we create a sort of wysiwyg Site card editing interface.

The tag line would go below that in a separate compact card with language.

I'm not really sure visibility then would need it's own separate card. I don't love that we tried to get rid of the top and bottom save buttons by adding even more of them.

Member

rickybanister commented Dec 16, 2015

This gave me an idea—I think the address should be the second item, right below the title. That mimics the Site card.

We should then put the blavatar interface to the left of those two fields and we create a sort of wysiwyg Site card editing interface.

The tag line would go below that in a separate compact card with language.

I'm not really sure visibility then would need it's own separate card. I don't love that we tried to get rid of the top and bottom save buttons by adding even more of them.

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Dec 16, 2015

Member

We should then put the blavatar interface to the left of those two fields and we create a sort of wysiwyg Site card editing interface.

Good idea. :)

Looping @adambbecker here as well.

Member

mtias commented Dec 16, 2015

We should then put the blavatar interface to the left of those two fields and we create a sort of wysiwyg Site card editing interface.

Good idea. :)

Looping @adambbecker here as well.

@mikeshelton1503

This comment has been minimized.

Show comment
Hide comment
@mikeshelton1503

mikeshelton1503 Dec 17, 2015

Contributor

👍 LGTM

This gave me an idea—I think the address should be the second item, right below the title. That mimics the Site card.

+1

Contributor

mikeshelton1503 commented Dec 17, 2015

👍 LGTM

This gave me an idea—I think the address should be the second item, right below the title. That mimics the Site card.

+1

@alternatekev

This comment has been minimized.

Show comment
Hide comment
@alternatekev

alternatekev Dec 17, 2015

Contributor

@mikeshelton1503 @rickybanister So Site Address would lose the bordering I've given it here, right? That's fine, I just wanted to confirm.

Contributor

alternatekev commented Dec 17, 2015

@mikeshelton1503 @rickybanister So Site Address would lose the bordering I've given it here, right? That's fine, I just wanted to confirm.

@rickybanister

This comment has been minimized.

Show comment
Hide comment
@rickybanister

rickybanister Dec 17, 2015

Member

Well, I guess eventually. We don't have a blavatar interface yet. I'd say your change could get merged (if other's agree) and just keep the whole Site card style interface idea bubbling for later....

Member

rickybanister commented Dec 17, 2015

Well, I guess eventually. We don't have a blavatar interface yet. I'd say your change could get merged (if other's agree) and just keep the whole Site card style interface idea bubbling for later....

cleaned up modules for jetpack and site profile
removed redundant headers

tidies up the form a bit

removes the is-magic classname to show save buttons by default again

removed extraneous is-magic class from css
@mikeshelton1503

This comment has been minimized.

Show comment
Hide comment
@mikeshelton1503

mikeshelton1503 Dec 17, 2015

Contributor

Well, I guess eventually. We don't have a blavatar interface yet. I'd say your change could get merged (if other's agree) and just keep the whole Site card style interface idea bubbling for later....

I agree. It doesn't need to happen right now but I like the idea of it for the future.

Contributor

mikeshelton1503 commented Dec 17, 2015

Well, I guess eventually. We don't have a blavatar interface yet. I'd say your change could get merged (if other's agree) and just keep the whole Site card style interface idea bubbling for later....

I agree. It doesn't need to happen right now but I like the idea of it for the future.

{ this.languageOptions() }
{ this.holidaySnowOption() }
</form>
</Card>
<SectionHeader label={ this.translate( 'Address and visibility' ) }>
<SectionHeader label={ this.translate( 'Visibility' ) }>
<Button

This comment has been minimized.

@roccotripaldi

roccotripaldi Dec 17, 2015

Member

This is an added bonus - because Jetpack sites do not require the custom address controls, so the 'Address and Visibility' label is a bit confusing there. Now it will be just 'Visibility' . Win win!

@roccotripaldi

roccotripaldi Dec 17, 2015

Member

This is an added bonus - because Jetpack sites do not require the custom address controls, so the 'Address and Visibility' label is a bit confusing there. Now it will be just 'Visibility' . Win win!

@roccotripaldi

This comment has been minimized.

Show comment
Hide comment
@roccotripaldi

roccotripaldi Dec 17, 2015

Member

Code looks solid. No errors and the custom address controls still work in the new layout. LGTM!

I agree that the blavatar could be handled in an other PR.

Member

roccotripaldi commented Dec 17, 2015

Code looks solid. No errors and the custom address controls still work in the new layout. LGTM!

I agree that the blavatar could be handled in an other PR.

alternatekev added a commit that referenced this pull request Dec 17, 2015

Merge pull request #1682 from Automattic/try/move-site-address-to-sit…
…e-profile

Site Settings: Moves Site Address up to Site Profile card

@alternatekev alternatekev merged commit a009258 into master Dec 17, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alternatekev alternatekev deleted the try/move-site-address-to-site-profile branch Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment