Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Site Settings: Update all sections to use SectionHeader #1898
@alternatekev the code looks mostly good but I had questions about the
There are also several other aesthetic issues that could be improved here but they belong in another PR. These are things like code formatting, splitting translation strings into multiple lines, etc…
If nobody has volunteered to do a design review yet, then it would be appropriate to ping someone directly and ask for their help. Please feel free to ping me again if this sits in queue again for an extended period.
referenced this pull request
Jan 13, 2016
@alternatekev: Design wise, this is looking nice (focusing on the section header stuff)! Good update for sure consistency wise. It's definitely better to have all the sections looking similar. Even though, as @dmsnell mentioned there are lots of other improvements to be made overall, focusing on just the headers for this PR makes sense.
Jetpack option added
One thing I did notice that was a bit out of the section header scope was the addition of this Jetpack site option.
Personally, I think we could leave that addition out of this current PR mostly because it could be split out to include it's own PR which could include some tweaks such as:
Messaging copy pass
Seems a little unclear to me on first read, could be something like (if I'm understanding the option correctly):
I did check / uncheck (& save) this option and it seemed to sync all the posts / pages (drafts, scheduled, etc.) for the Jetpack site regardless of whether this option was checked. So I'm not entirely sure what the unchecked state actually does.
Section header multiple buttons
I noticed there was a spacing solution added to the section header button (disconnect in this case) that could probably be expanded for all section headers. Margin by default to account for multiple buttons or button groups with the last child removing said margin, etc.
@rralian: Don't know if you wanted to take a look at the code here real quick being the OG for settings code.
@adambbecker Yep that code isn't available on production. This PR doesn't enable it. I had some problems because of that with earlier updates of this page.
Essentially: that copy/UI won't really show up at all until the feature is ready to go. The only button you get until then is Disconnect.
Totally agree on that one. I can do a new PR for SectionHeader to fix that,
So it looks like:
@enejb @roccotripaldi It doesn't look like this feature is enabled on Production. Is that correct? Can we disable these UIs in the non-production environments, too, until they're ready? And by "they" I mean:
Seeing everything in action does make me really wish the form sections were more separated, but I understand why they are not currently: save buttons not actually being separate saves, etc.. But that being said, do you think it's worth trying the technique where there are separated sections, but not all the "save" buttons are immediately visible? They would only become visible if a setting in that section was changed. That would hopefully cut down on the primary button clutter a bit while still having the smaller, separated, and focused forms.
@mtias & @adambbecker I've updated this PR to walk back the General Settings so they're back in separate Cards. All this PR does to that page now is move Jetpack Settings to the very bottom. Take a look and we can get a new PR started for the hide/show buttons interaction.
The only thing that really stood out to me was that all of the analytics tracking is causing ESLint warnings because they use
I did go ahead and address a few other ESLint issues such as unused variables and ternary style.
I left one comment about potentially using a
If you're fine with my changes, go ahead and