Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Downloading media library archive from the export page. #27581
Changes proposed in this Pull Request
A user can click on the "Download" button in the card to download an archive of the media library.
In summary, it includes:
This PR is built on #27578.
referenced this pull request
Oct 3, 2018
Thanks for taking a look, @michelleweber :)
Good question. To be specific, "an archive" here means an archive file in the
changed the base branch from
Oct 4, 2018
I left several comments, but most of them are minor. Note I couldn't apply the server patch as some hunks could not be applied cleanly by the unix 'patch' utility.
@stephanethomas Thanks for the insightful review.
Sorry that I didn't update the test plan in advance. It is not necessary anymore since all the backend changes has been deployed. That also means the feature flag,
When you have some time, please have a revisit to see if I've addressed all your concerns the right way. Thanks :)
If I'm not mistaken, the common practices for this when using is to set clickableHeader as true so that the whole card can be clicked to expand. I've also update the sentence as Or click here to select specific content items to export to emphasize that it can be clicked.
The problem I see with this approach is that the foldable card is not used to show more information about the action that can be performed when the call-to-action (i.e. the
Export All button) is clicked. On the contrary, it is used to offer a different export option to the user which also comes with its own call-to-action.
I'm not a big fan of a
click here text that doesn't have link - as users may wonder if something is missing. I think we could also be more consistent among our different export sections. So right now we have the following:
I'd like to propose the following changes:
Let me know what you think of it. I will approve this pull request in the meantime as it doesn't require another review from my point of view, and anything proposed here is optional.
As an aside, it's interesting to see that exporting images is instantaneous while exporting text content - which should be much lighter - requires a job and an email to be sent to the user.
A summary of our discussion: