New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update module headers to SectionHeader #2863

Merged
merged 8 commits into from Apr 1, 2016

Conversation

Projects
None yet
9 participants
@alternatekev
Contributor

alternatekev commented Jan 27, 2016

This PR takes the current Stats modules and standardizes on the SectionHeader components:

untitled-4
untitled-3
untitled-2

cc @jancavan

@jancavan

This comment has been minimized.

Show comment
Hide comment
@jancavan

jancavan Jan 27, 2016

Contributor

Good job updating these! I have a couple comments:

  1. When I click on the graph icon, I'm taken to the full listing, but clicking this again (from the full list) jumps to an empty page. I don't think the graph icons communicate very well that clicking them means you'll be taken to the full list. It felt like it was going to take me to some additional stats for that particular module. It may just be the type of icon, but I think we can also just remove them since we already have "View all" which works great.
    UPDATE: The "Latest Post Summary" module could probably retain this icon though since clicking it actually takes you to additional stats for that post.
  2. On Today's Stats and All-time modules, there's a very faint drop shadow (or border?) right under the SectionHeading's bottom border.
  3. On the Post Summary (Post & Pages module > click on a post), info icons are still there.

Other than those comments, it's looking good. The modules look much cleaner!

Contributor

jancavan commented Jan 27, 2016

Good job updating these! I have a couple comments:

  1. When I click on the graph icon, I'm taken to the full listing, but clicking this again (from the full list) jumps to an empty page. I don't think the graph icons communicate very well that clicking them means you'll be taken to the full list. It felt like it was going to take me to some additional stats for that particular module. It may just be the type of icon, but I think we can also just remove them since we already have "View all" which works great.
    UPDATE: The "Latest Post Summary" module could probably retain this icon though since clicking it actually takes you to additional stats for that post.
  2. On Today's Stats and All-time modules, there's a very faint drop shadow (or border?) right under the SectionHeading's bottom border.
  3. On the Post Summary (Post & Pages module > click on a post), info icons are still there.

Other than those comments, it's looking good. The modules look much cleaner!

@folletto

This comment has been minimized.

Show comment
Hide comment
@folletto

folletto Jan 29, 2016

Member

"Posting activity" on background instead of white created a nice variation in style, but it's just a personal preference. :)

Apart from that, I like the change. :)

Member

folletto commented Jan 29, 2016

"Posting activity" on background instead of white created a nice variation in style, but it's just a personal preference. :)

Apart from that, I like the change. :)

@jancavan

This comment has been minimized.

Show comment
Hide comment
@jancavan

jancavan Jan 30, 2016

Contributor

Another minor thing I noticed are the extra empty squares on the Posting Activity.

Contributor

jancavan commented Jan 30, 2016

Another minor thing I noticed are the extra empty squares on the Posting Activity.

@alternatekev

This comment has been minimized.

Show comment
Hide comment
@alternatekev

alternatekev Mar 2, 2016

Contributor

@dmsnell can i get a review on this?

Contributor

alternatekev commented Mar 2, 2016

@dmsnell can i get a review on this?

Show outdated Hide outdated client/my-sites/stats/all-time/index.jsx
<SectionHeader label={ this.translate( 'All-time posts, views, and visitors' ) }></SectionHeader>
<Card className={ classNames( 'stats-module', 'stats-all-time', classes ) }>
<div className="module-content">
<div className="module-content-text module-content-text-info">

This comment has been minimized.

@timmyc

timmyc Mar 9, 2016

Member

If the info toggles are no more, we can rip out these div's. Sounds like we should do a follow up PR and remove all info / toggle logic once this PR lands.

@timmyc

timmyc Mar 9, 2016

Member

If the info toggles are no more, we can rip out these div's. Sounds like we should do a follow up PR and remove all info / toggle logic once this PR lands.

Show outdated Hide outdated calypso
@@ -0,0 +1 @@
calypso

This comment has been minimized.

@timmyc

timmyc Mar 9, 2016

Member

:wut: this needs to be deleted.

@timmyc

timmyc Mar 9, 2016

Member

:wut: this needs to be deleted.

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 9, 2016

Member

A bit more sweeping done on this branch. After this is merged we can do away with the mixin-* files in stats too 🎉

4909647 - Removed info boxes / toggle logic from various components
02a18cd - Removes the view all gridicon from components on the insights page that have no summary pages ( Tags & Categories, Publicize )
5627e00 - Fixes up the follower summary page to use the new header design

From our discussion in slack, we are going to punt for now on removing the (i) icons from the post summary pages.

@alternatekev and @jancavan if you could both give this branch another test drive after these updates that would be excellent.

Member

timmyc commented Mar 9, 2016

A bit more sweeping done on this branch. After this is merged we can do away with the mixin-* files in stats too 🎉

4909647 - Removed info boxes / toggle logic from various components
02a18cd - Removes the view all gridicon from components on the insights page that have no summary pages ( Tags & Categories, Publicize )
5627e00 - Fixes up the follower summary page to use the new header design

From our discussion in slack, we are going to punt for now on removing the (i) icons from the post summary pages.

@alternatekev and @jancavan if you could both give this branch another test drive after these updates that would be excellent.

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 10, 2016

Member

Also want to summarize some of the big changes in the branch for anyone wanting to check it out:

  • Removes (i) info icons from the header
  • Removes collapse option for modules
  • Header Text is no longer linked to summary pages when applicable
  • "View All" links have also been removed from the footer to summary pages

Before
stats_ _trout_bummin_ _wordpress_com

After
stats_ _trout_bummin_ _wordpress_com

Note: Only gridicon now links to summary pages ( when available )

Member

timmyc commented Mar 10, 2016

Also want to summarize some of the big changes in the branch for anyone wanting to check it out:

  • Removes (i) info icons from the header
  • Removes collapse option for modules
  • Header Text is no longer linked to summary pages when applicable
  • "View All" links have also been removed from the footer to summary pages

Before
stats_ _trout_bummin_ _wordpress_com

After
stats_ _trout_bummin_ _wordpress_com

Note: Only gridicon now links to summary pages ( when available )

@jancavan

This comment has been minimized.

Show comment
Hide comment
@jancavan

jancavan Mar 10, 2016

Contributor

Thanks for wrangling this @timmyc and @alternatekev. The section header looks nice and clean.

I think everything else looks good, but I don't think we should be removing "View all". It's not obvious that clicking on the graph icon takes you to the entire list and it's also really not the right symbol for it - a graph that takes you to a list item. The module heading should at least be clickable if we're removing "View all", but my vote is to add it back.

Contributor

jancavan commented Mar 10, 2016

Thanks for wrangling this @timmyc and @alternatekev. The section header looks nice and clean.

I think everything else looks good, but I don't think we should be removing "View all". It's not obvious that clicking on the graph icon takes you to the entire list and it's also really not the right symbol for it - a graph that takes you to a list item. The module heading should at least be clickable if we're removing "View all", but my vote is to add it back.

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 10, 2016

Member

@alternatekev shall I add the footer/view all back in?

Member

timmyc commented Mar 10, 2016

@alternatekev shall I add the footer/view all back in?

@alternatekev

This comment has been minimized.

Show comment
Hide comment
@alternatekev

alternatekev Mar 10, 2016

Contributor

I’m walking through this with Sheri today in order to get a better feel for where she thinks users will get tripped up. I’d almost like to investigate using a clickable compact Card instead of SectionHeader here since that uses the full bar to click and has a more appropriate default icon (the right-facing chevron).

Contributor

alternatekev commented Mar 10, 2016

I’m walking through this with Sheri today in order to get a better feel for where she thinks users will get tripped up. I’d almost like to investigate using a clickable compact Card instead of SectionHeader here since that uses the full bar to click and has a more appropriate default icon (the right-facing chevron).

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 10, 2016

Member

Updating the status until we have some direction on that.

Member

timmyc commented Mar 10, 2016

Updating the status until we have some direction on that.

@dmsnell

This comment has been minimized.

Show comment
Hide comment
@dmsnell

dmsnell Mar 10, 2016

Contributor

@dmsnell can i get a review on this?

sorry @alternatekev I don't think I'll be able to right now

Contributor

dmsnell commented Mar 10, 2016

@dmsnell can i get a review on this?

sorry @alternatekev I don't think I'll be able to right now

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 11, 2016

Member

@alternatekev & @jancavan "View All" links added back in 4032165

Member

timmyc commented Mar 11, 2016

@alternatekev & @jancavan "View All" links added back in 4032165

@jancavan

This comment has been minimized.

Show comment
Hide comment
@jancavan

jancavan Mar 11, 2016

Contributor

Having "View all" feels more intuitive to me.

Contributor

jancavan commented Mar 11, 2016

Having "View all" feels more intuitive to me.

@folletto

This comment has been minimized.

Show comment
Hide comment
@folletto

folletto Mar 11, 2016

Member

+1 to "View all".

I'd note that "View all" is even more important than it might look, since it's the only link that leads to a page where people can export data.

screen shot 2016-03-11 at 10 47 46

I recall at least one user that was asking on how to export it, but since the list was too short, there was no way to access the download link. This should call for a redesign maybe, or maybe just keeping the link always present, and re-labelling it as "Details" or something similar.

Member

folletto commented Mar 11, 2016

+1 to "View all".

I'd note that "View all" is even more important than it might look, since it's the only link that leads to a page where people can export data.

screen shot 2016-03-11 at 10 47 46

I recall at least one user that was asking on how to export it, but since the list was too short, there was no way to access the download link. This should call for a redesign maybe, or maybe just keeping the link always present, and re-labelling it as "Details" or something similar.

@alternatekev

This comment has been minimized.

Show comment
Hide comment
@alternatekev

alternatekev Mar 11, 2016

Contributor
Contributor

alternatekev commented Mar 11, 2016

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 11, 2016

Member

@alternatekev marking this as ready for review again - I think you might have one more change for the gridicon, but other than that this is ready to be tested by others.

Member

timmyc commented Mar 11, 2016

@alternatekev marking this as ready for review again - I think you might have one more change for the gridicon, but other than that this is ready to be tested by others.

Show outdated Hide outdated client/my-sites/stats/post-trends/style.scss
.post-trends__year {
margin: 0 40px 0;
}
}

This comment has been minimized.

@nylen

nylen Mar 29, 2016

Contributor

Should just remove this now-empty block.

@nylen

nylen Mar 29, 2016

Contributor

Should just remove this now-empty block.

This comment has been minimized.

@alternatekev

alternatekev Mar 29, 2016

Contributor

@nylen fixed!

@alternatekev

alternatekev Mar 29, 2016

Contributor

@nylen fixed!

Show outdated Hide outdated client/my-sites/stats/all-time/index.jsx
const user = User();
export default React.createClass( {
displayName: 'StatsAllTime',
mixins: [ toggle( 'allTimeList' ), observe( 'allTimeList' ) ],
mixins: [observe( 'allTimeList' ) ],

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

space needed here [ observe

@timmyc

timmyc Mar 29, 2016

Member

space needed here [ observe

This comment has been minimized.

@alternatekev

alternatekev Mar 29, 2016

Contributor

@timmyc fixed

Show outdated Hide outdated client/my-sites/stats/stats-countries/index.jsx
displayName: 'StatCountries',
mixins: [ toggle( 'Countries' ), skeleton( 'data' ), observe( 'dataList' ) ],
mixins: [ toggle( 'Countries' ), observe( 'dataList' ) ],

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

hmmm I thought this was removed, but we should be able to rip out toggle( 'Countries' ) and the import above as well.

@timmyc

timmyc Mar 29, 2016

Member

hmmm I thought this was removed, but we should be able to rip out toggle( 'Countries' ) and the import above as well.

Show outdated Hide outdated client/my-sites/stats/stats-countries/index.jsx
@@ -77,71 +76,55 @@ module.exports = React.createClass( {
mapData.push( [ country.label, country.value ] );
} );
summaryPageLink = '/stats/' + this.props.period.period + '/countryviews/' + this.props.site.slug + '?startDate=' + this.props.date;
const summaryPageLink = '/stats/' + this.props.period.period + '/countryviews/' + this.props.site.slug + '?startDate=' + this.props.date;
const geochart = <Geochart data={ mapData } dataList={ this.props.dataList } />;

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

I don't think we need to define these as consts here ( and countries below ), just have the component calls inline where they are being used.

@timmyc

timmyc Mar 29, 2016

Member

I don't think we need to define these as consts here ( and countries below ), just have the component calls inline where they are being used.

if ( touchDetect.hasTouch() ) {
return null;
}

This comment has been minimized.

@nylen

nylen Mar 29, 2016

Contributor

There is almost certainly a better way to do this. Probably a client width check. hasTouch doesn't work as intended on a lot of newer laptops with touchscreens, and chances are this control works fine on iPads and other large tablets. See #1479 for more details about why not to use this.

Arguably out of scope for this PR since it was there before, but also an opportunity to get rid of a bad practice.

@nylen

nylen Mar 29, 2016

Contributor

There is almost certainly a better way to do this. Probably a client width check. hasTouch doesn't work as intended on a lot of newer laptops with touchscreens, and chances are this control works fine on iPads and other large tablets. See #1479 for more details about why not to use this.

Arguably out of scope for this PR since it was there before, but also an opportunity to get rid of a bad practice.

This comment has been minimized.

@timmyc

timmyc Mar 30, 2016

Member

@nylen will not rest until touchDetect is dead. :trollface:

@timmyc

timmyc Mar 30, 2016

Member

@nylen will not rest until touchDetect is dead. :trollface:

Show outdated Hide outdated client/my-sites/stats/stats-module/index.jsx
var noSummaryPages = [ 'tags-categories', 'publicize' ];
return -1 === noSummaryPages.indexOf( this.props.path );
viewAll() {
var summaryPageLink;

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

should be a let

@timmyc

timmyc Mar 29, 2016

Member

should be a let

Show outdated Hide outdated client/my-sites/stats/stats-module/index.jsx
if ( this.props.beforeNavigate ) {
this.props.beforeNavigate();
}
return summaryPageLink;

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

and this return needs to be outside of the if block

@timmyc

timmyc Mar 29, 2016

Member

and this return needs to be outside of the if block

Show outdated Hide outdated client/my-sites/stats/stats-module/index.jsx
hasSummaryPage: function() {
var noSummaryPages = [ 'tags-categories', 'publicize' ];
return -1 === noSummaryPages.indexOf( this.props.path );
viewAll() {

This comment has been minimized.

@timmyc

timmyc Mar 29, 2016

Member

Something feels kind of funky here. I don't know if we need this method but need to look a bit further. If all we need to do is generate the URL we could do this logic in getHref

@timmyc

timmyc Mar 29, 2016

Member

Something feels kind of funky here. I don't know if we need this method but need to look a bit further. If all we need to do is generate the URL we could do this logic in getHref

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Mar 31, 2016

Member

@alternatekev if you don't mind doing one last test pass then we can get this merged in ( finally ).

Member

timmyc commented Mar 31, 2016

@alternatekev if you don't mind doing one last test pass then we can get this merged in ( finally ).

alternatekev and others added some commits Jan 27, 2016

updated insights to use section-header
modified stats-module to use sectionheader

css fixes to module sectionheaders

module text padding

updated insights to use section-header

css fixes to module sectionheaders

module text padding

fixed issues with the scrolly part of the post trends visualization

updated insights to use section-header

modified stats-module to use sectionheader

css fixes to module sectionheaders

module text padding

updated insights to use section-header

css fixes to module sectionheaders

module text padding

fixed issues with the scrolly part of the post trends visualization

updated insights to use section-header

css fixes to module sectionheaders

module text padding

updated insights to use section-header

css fixes to module sectionheaders

module text padding

fixed issues with the scrolly part of the post trends visualization

updated insights to use section-header

modified stats-module to use sectionheader

css fixes to module sectionheaders

module text padding

updated insights to use section-header

css fixes to module sectionheaders

module text padding

fixed issues with the scrolly part of the post trends visualization

fixes to sectionheaders & view all buttons/icons

es6 upgrades and formatting cleanup

es6 upgrades and formatting cleanup

removed extraneous left/right arrows from post-trends

added use of containerClass var

fixed scroll bug on post-trends

added borderless prop to stats-tabs to remove shadow effect from insights page

removed extra icon

removed extra site icon

Removing unused toggle/info logic.

Fix up lint errors.

Use props.period to handle instances where modules do not have summary pages.

Clean up header on followers page.

Add View All links back in.

changed chart icon to chevron-right
# This is a combination of 2 commits.
# The first commit's message is:

updated sectionheaders to use href prop instead of action buttons

# This is the 2nd commit message:

removed extraneous vars
@designsimply

This comment has been minimized.

Show comment
Hide comment
@designsimply

designsimply Apr 1, 2016

Contributor

Tested update/stats-standard-ui with Firefox 45.0.1 on Mac OS X 10.11.13

Video walkthrough: 7m51s

Nitpicks/Observations

  1. Fast mouseover on the posting activity graph result in popover artifacts (Firefox-only)
  2. Wasn't sure why some tags are grouped
  3. Not every card has a detailed summary page
  4. I miss the info button, unfortunately
  5. Some summary page headers have a lot of white space at the top, but users want to see more stuff in less space when it comes to stats—they want less scrolling
  6. "Download Data" button is at the bottom on the Followers summary pages but at the top on other pages (i.e. Countries)
  7. "Download Data" button should not be present if the page is empty
  8. The comment follower link is the odd one out being the only one without an arrow or "view all" link—which makes sense because it's not a summary view of the card data… but that link is still oddly placed imo—would rather see total comments number and comment followers as a dropdown selection instead
  9. Info text for "Average per Day" graph on the post detail view doesn't mention that the stat is "average per day"—also, maybe we can be more selective about where we put info buttons and only add them on things ask about the most (the explanations on that page seem terribly obvious to me…)

Most of this list is out of scope for this PR, so I can raise issues separately for any of them that are worth moving forward. Moving the email followers download button to top right is probably the only suggestion I'd make for including now if it can be updated in this round of changes.

Even though users may miss the "View All" links because they are used to it, I think we could still try removing it. A temporary explanation popover could help die-hard stats lovers transition to the more stream-lined design without needing the "View All" link—and then we could test our assumptions with a few user tests to see if any new users cannot figure out how to get to summary pages.

Contributor

designsimply commented Apr 1, 2016

Tested update/stats-standard-ui with Firefox 45.0.1 on Mac OS X 10.11.13

Video walkthrough: 7m51s

Nitpicks/Observations

  1. Fast mouseover on the posting activity graph result in popover artifacts (Firefox-only)
  2. Wasn't sure why some tags are grouped
  3. Not every card has a detailed summary page
  4. I miss the info button, unfortunately
  5. Some summary page headers have a lot of white space at the top, but users want to see more stuff in less space when it comes to stats—they want less scrolling
  6. "Download Data" button is at the bottom on the Followers summary pages but at the top on other pages (i.e. Countries)
  7. "Download Data" button should not be present if the page is empty
  8. The comment follower link is the odd one out being the only one without an arrow or "view all" link—which makes sense because it's not a summary view of the card data… but that link is still oddly placed imo—would rather see total comments number and comment followers as a dropdown selection instead
  9. Info text for "Average per Day" graph on the post detail view doesn't mention that the stat is "average per day"—also, maybe we can be more selective about where we put info buttons and only add them on things ask about the most (the explanations on that page seem terribly obvious to me…)

Most of this list is out of scope for this PR, so I can raise issues separately for any of them that are worth moving forward. Moving the email followers download button to top right is probably the only suggestion I'd make for including now if it can be updated in this round of changes.

Even though users may miss the "View All" links because they are used to it, I think we could still try removing it. A temporary explanation popover could help die-hard stats lovers transition to the more stream-lined design without needing the "View All" link—and then we could test our assumptions with a few user tests to see if any new users cannot figure out how to get to summary pages.

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Apr 1, 2016

Member

Even though users may miss the "View All" links, I think we could still try removing it. A temporary explanation popover could help die-hard stats lovers transition to the more stream-lined design without needing the "View All" link—and then we could test our assumptions with a few user tests to see if any new users cannot figure out how to get to summary pages.

I think this would be totally worth trying too, perhaps in a follow-up PR though. There are some big changes afoot here already - namely removing of the collapse toggle for modules ( which were persisted in localStorage ), and to some extent the (i) buttons - though those probably aren't used by power users of stats.

My biggest concern with making too many changes here is the fact that there is not a team dedicated to working on stats right now. I think that even this PR will potentially generate some feedback that might require follow-up PRs.

All of your ideas/issues outlined above are great feedback and really should be worked on, but until we can dedicate some dev/design resources around this we need to be careful to not change too much.

Member

timmyc commented Apr 1, 2016

Even though users may miss the "View All" links, I think we could still try removing it. A temporary explanation popover could help die-hard stats lovers transition to the more stream-lined design without needing the "View All" link—and then we could test our assumptions with a few user tests to see if any new users cannot figure out how to get to summary pages.

I think this would be totally worth trying too, perhaps in a follow-up PR though. There are some big changes afoot here already - namely removing of the collapse toggle for modules ( which were persisted in localStorage ), and to some extent the (i) buttons - though those probably aren't used by power users of stats.

My biggest concern with making too many changes here is the fact that there is not a team dedicated to working on stats right now. I think that even this PR will potentially generate some feedback that might require follow-up PRs.

All of your ideas/issues outlined above are great feedback and really should be worked on, but until we can dedicate some dev/design resources around this we need to be careful to not change too much.

@designsimply

This comment has been minimized.

Show comment
Hide comment
@designsimply

designsimply Apr 1, 2016

Contributor

@timmyc, would you be willing to remove "View All" links now and just revert sooner than later if users complain too much? (I can help track user feedback for this.)

Contributor

designsimply commented Apr 1, 2016

@timmyc, would you be willing to remove "View All" links now and just revert sooner than later if users complain too much? (I can help track user feedback for this.)

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Apr 1, 2016

Member

would you be willing to remove "View All" links now and just revert sooner than later if users complain too much?

Sounds good to me, but we also need to give ti some time to get a good amount of feedback. Also need to give a heads up to all HE's as I think there will be questions around the change.

Member

timmyc commented Apr 1, 2016

would you be willing to remove "View All" links now and just revert sooner than later if users complain too much?

Sounds good to me, but we also need to give ti some time to get a good amount of feedback. Also need to give a heads up to all HE's as I think there will be questions around the change.

@alternatekev

This comment has been minimized.

Show comment
Hide comment
@alternatekev

alternatekev Apr 1, 2016

Contributor

@timmyc I've moved the Email Followers download button into the SectionHeader.

Contributor

alternatekev commented Apr 1, 2016

@timmyc I've moved the Email Followers download button into the SectionHeader.

@timmyc

This comment has been minimized.

Show comment
Hide comment
@timmyc

timmyc Apr 1, 2016

Member

LGTM. I think we should get this out the door and follow up with the view-all links.

Member

timmyc commented Apr 1, 2016

LGTM. I think we should get this out the door and follow up with the view-all links.

@jancavan

This comment has been minimized.

Show comment
Hide comment
@jancavan

jancavan Apr 1, 2016

Contributor

Thanks for the thorough review @designsimply. I'm still leaning towards keep "View all", but I think the new change to the chevron icon is much more intuitive than the previous version.

Wasn't sure why some tags are grouped

This has always been like this (I think) even before it was ported over and we didn't get around to make this better and yes, it's confusing.

Contributor

jancavan commented Apr 1, 2016

Thanks for the thorough review @designsimply. I'm still leaning towards keep "View all", but I think the new change to the chevron icon is much more intuitive than the previous version.

Wasn't sure why some tags are grouped

This has always been like this (I think) even before it was ported over and we didn't get around to make this better and yes, it's confusing.

@alternatekev alternatekev merged commit 3dc2a69 into master Apr 1, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@folletto

This comment has been minimized.

Show comment
Hide comment
@folletto

folletto Apr 4, 2016

Member

A user noted of a bug with "View all", maybe it's related to some changes here? See #4507.

Member

folletto commented Apr 4, 2016

A user noted of a bug with "View all", maybe it's related to some changes here? See #4507.

@lancewillett

This comment has been minimized.

Show comment
Hide comment
@lancewillett

lancewillett May 2, 2016

Member

Fast mouseover on the posting activity graph result in popover artifacts (Firefox-only)

New issue raised for this: #5162

Member

lancewillett commented May 2, 2016

Fast mouseover on the posting activity graph result in popover artifacts (Firefox-only)

New issue raised for this: #5162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment