Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Guided Transfer Card Unavailable Info Icon style #34735

Merged
merged 1 commit into from Jul 22, 2019
Merged

Fix Guided Transfer Card Unavailable Info Icon style #34735

merged 1 commit into from Jul 22, 2019

Conversation

diegohaz
Copy link
Contributor

@diegohaz diegohaz commented Jul 17, 2019 •
edited

Changes proposed in this Pull Request

  • Fix Guided Transfer Card Unavailable Info Icon style

Testing instructions

  1. Go to /export
  2. Update this snippet to show the UnavailableInfo component:

    wp-calypso/client/my-sites/exporter/guided-transfer-card/index.jsx

    Lines 75 to 87 in 4612c22

    <div className="guided-transfer-card__options-header-button-container">
    { isAvailable || isRequestingStatus ? (
    <Button
    href={ `/export/guided/${ siteSlug }` }
    isPrimary={ false }
    disabled={ isRequestingStatus }
    >
    { translate( 'Purchase a Guided Transfer' ) }
    </Button>
    ) : (
    <UnavailableInfo />
    ) }
    </div>
Before

With wrong icon color

After

With right icon color

@diegohaz diegohaz requested a review from a team July 17, 2019 22:21
@diegohaz diegohaz self-assigned this Jul 17, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/css-guided-transfer-card

@diegohaz diegohaz added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 17, 2019
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@diegohaz diegohaz mentioned this pull request Jul 17, 2019
Merged
jsnajdr
jsnajdr approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢

@diegohaz diegohaz merged commit cbacd79 into master Jul 22, 2019
@diegohaz diegohaz deleted the fix/css-guided-transfer-card branch July 22, 2019 13:07
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees

@diegohaz diegohaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diegohaz @matticbot @jsnajdr