Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevDocs: Fix broken links on certain pages #35699

Merged

Conversation

@anuragbhd
Copy link
Contributor

commented Aug 22, 2019

Changes proposed in this Pull Request

Testing instructions

  • Visit the UI Components page and click component documentation link. Currently it redirects to a 404 page, but after the fix it will redirect to the intended page.

  • Visit the Blocks page and click blocks documentation link. Currently it redirects to a 404 page, but after the fix it will redirect to the intended page.

Fixes #35690

CC @sirreal @retrofox

@bluefuton
Copy link
Contributor

left a comment

Looks good to me 🚢 Thanks for your contribution @anuragbhd!

@bluefuton bluefuton merged commit 8d268f8 into Automattic:master Aug 22, 2019

13 checks passed

a8c/valid-pr This check is used to prevent accidental commits to master.
Details
ci/circleci: build-full-site-editing Your tests passed on CircleCI!
Details
ci/circleci: build-notifications Your tests passed on CircleCI!
Details
ci/circleci: build-o2-blocks Your tests passed on CircleCI!
Details
ci/circleci: build-wpcom-block-editor Your tests passed on CircleCI!
Details
ci/circleci: icfy-stats Your tests passed on CircleCI!
Details
ci/circleci: lint-and-translate Your tests passed on CircleCI!
Details
ci/circleci: prime-calypso-live Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-client Your tests passed on CircleCI!
Details
ci/circleci: test-packages Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: typecheck Your tests passed on CircleCI!
Details

@anuragbhd anuragbhd deleted the anuragbhd:fix/broken-links-on-devdocs-pages branch Aug 23, 2019

@anuragbhd

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@bluefuton Thanks for approving and merging my first PR 😁. That gives me all the motivation to hunt down more issues and fix them, moving gradually up in terms of difficulty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.