Add mp4 Files to the Webpack Loader

[Aurorum]

Changes proposed in this Pull Request

This adds mp4 files to the Webpack loader (for examples of future usage, see #39617).

Testing instructions

I changed the video in the Free Photo Library Card to test his. You can head to Customer Home, and start the video in that card. Verify through the link that the file is loaded, and that it plays properly.

[mmtr]

Thanks @Aurorum! Just a nitpick: I found weird the video to be in the images folder. Is there any reason why we can't create a videos directory?

[jsnajdr]

Unfortunately, there are several more places that need to be updated, too:

• the file loader in wp-desktop webpack config file here: https://github.com/Automattic/wp-desktop/blob/develop/webpack.shared.js#L51-L60 This webpack config is used to build the Node.js/Electron server for the Desktop app. Very similar to the Calypso server build, but slightly differently configured 🙂
• the Jest configs for tests. Jest doesn't use webpack and needs to be told how to interpret the asset files: https://github.com/Automattic/wp-calypso/blob/master/test/client/jest.config.js#L5-L10 There are 3 or 4 files like this: jest-preset.js in calypso-build, configs for client and server, one README.md file...

[Aurorum]

Thanks @mmtr and @jsnajdr! :)

Unfortunately, there are several more places that need to be updated, too

I've tried to update as many as I can find, and have opened a PR in Automattic/wp-desktop#789 for the case you linked.

Is there any reason why we can't create a videos directory?

Nope, done! :)

[kwight]

@Aurorum great video! 🐯

I'm wondering about this approach down the line though, and questioning if we should have video files in the repo at all. Every video we add is at least another 2MB for every repo checkout – is this fair to do? ¯_(ツ)_/¯ I'll post internally with a few other questions too, to get some wider company clarity, we have a few different options.

[kwight]

Some internal discussion: p4TIVU-9n1-p2

[sixhours]

(Edit to the above comment to make the auto-linking to P2 functionality work.)

[Aurorum]

Thanks for checking whether or not this is the ideal approach! In the meantime, I've switched images to media.

[mmtr]

Some internal discussion: p4TIVU-9n1-p2

We finally decided that our marketing team will be making these videos and uploading them to our YouTube channel, so we won't need this loader for now.

Thanks anyway @Aurorum!

[Aurorum]

Thanks @mmtr! Could you please let me know when the videos are available to use in #39617? :)