Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the domain type in the domain settings header title #40697

Merged
merged 2 commits into from Apr 6, 2020

Conversation

hambai
Copy link
Contributor

@hambai hambai commented Apr 2, 2020

Changes proposed in this Pull Request

  • Update header title to help people distinguish different domain types

Before:

Screenshot 2020-04-02 at 11 21 10

After:

Screenshot 2020-04-02 at 11 21 27

Screenshot 2020-04-02 at 11 21 35

Screenshot 2020-04-02 at 11 22 59

Screenshot 2020-04-02 at 11 23 50

Testing instructions

  • Check the domain settings page for registered domain, mapped domain, wpcom domain or incoming transfer

@hambai hambai added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Apr 2, 2020
@hambai hambai requested review from fditrapani and a team April 2, 2020 08:25
@hambai hambai self-assigned this Apr 2, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Apr 2, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains        +43 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for the update.

The only minor change I would make is for Wpcom Domain Settings. Can we say Default Site Domain Settings?

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks for the update.

Copy link
Contributor

@olaseni olaseni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olaseni olaseni added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 3, 2020
@hambai hambai merged commit 5c353c2 into master Apr 6, 2020
@hambai hambai deleted the update/show-domain-type-in-header branch April 6, 2020 04:32
@akirk
Copy link
Member

akirk commented Jun 9, 2020

Unfortunately this is missing translatability. I've added it in #43102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants