Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Scaffold editor-domain-picker package #42702

Merged
merged 1 commit into from Jun 1, 2020
Merged

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 27, 2020

Changes proposed in this Pull Request

Scaffold a "editor-domain-picker" package:

  • package scripts for building
  • PHP enqueuing
  • "Feature flag" (A8C_FSE_DOMAIN_PICKER_ENABLE)
  • Some friendly placeholder JS to show the bundling is working.

Testing instructions

Apply D44014-code

Try with the following conditions (add to sandbox):

  • Nothing special defined (feature disabled)
  • define( 'A8C_FSE_DOMAIN_PICKER_ENABLE', false ); (feature disabled)
  • define( 'A8C_FSE_DOMAIN_PICKER_ENABLE', true ); (feature enabled)
  1. Sandbox a simple site and load the editor: you should see the friendly debugging messages on the console if the constant enables the feature.
  2. When not enabled, the script should not be enqueued, check for it in the network tab. editor-domain-picker and shared dependency common-data-stores.
  3. For other pages (not the block editor) nothing should be enqueued or run. Verify same behavior as when the feature is disabled.

No new/related PHP errors or warnings should be generated under any of the above conditions.

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D44014-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal marked this pull request as ready for review May 27, 2020 12:25
@sirreal sirreal requested a review from a team as a code owner May 27, 2020 12:25
@sirreal sirreal requested a review from a team May 27, 2020 12:25
@sirreal sirreal added [Goal] New Onboarding previously called Gutenboarding [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. and removed [Status] In Progress labels May 28, 2020
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and tested as instructed. All LGTM.

@sirreal sirreal merged commit 3be85c5 into master Jun 1, 2020
@sirreal sirreal deleted the add/fse-domain-picker branch June 1, 2020 11:51
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants