New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable creating reader lists #43164
Enable creating reader lists #43164
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~6 bytes added 馃搱 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~89 bytes added 馃搱 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~870 bytes added 馃搱 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Form text looks good 馃憤 Can we add |
@bluefuton: Added translations to form labels. The API route currently doesn't respect the |
D44850-code. |
Great stuff 馃憤 Working well for me (aside from the public flag - I'll check out the patch next!) How about having the route at |
One other note that we can address in a different PR - the new list doesn't appear in the sidebar. It is being correctly added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a suggested change of route to /read/list/new
, this works well - nice one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3821377 Thank you @jsnmoon for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
/read/list
)Testing instructions
/read/list
.