Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creating reader lists #43164

Merged
merged 13 commits into from Jun 12, 2020
Merged

Enable creating reader lists #43164

merged 13 commits into from Jun 12, 2020

Conversation

jsnmoon
Copy link
Member

@jsnmoon jsnmoon commented Jun 10, 2020

Screen Shot 2020-06-11 at 4 22 39 PM

Changes proposed in this Pull Request

  • Creates a route for creating a reader list (/read/list)
  • Enables the user to create a reader list

Testing instructions

  • Apply D44850-code to public-api.
  • Navigate to /read/list.
  • Enter a list name.
  • Press "Save".
  • 馃帀

@jsnmoon jsnmoon added the [Feature] Reader The reader site on Calypso. label Jun 10, 2020
@jsnmoon jsnmoon added this to the Reader List Management milestone Jun 10, 2020
@jsnmoon jsnmoon self-assigned this Jun 10, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jun 10, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 馃搱 [gzipped])

name        parsed_size           gzip_size
entry-main        +60 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~89 bytes added 馃搱 [gzipped])

name         parsed_size           gzip_size
reader            +508 B  (+0.1%)      +76 B  (+0.1%)
site-blocks       +105 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~870 bytes added 馃搱 [gzipped])

name                                             parsed_size           gzip_size
async-load-reader-list-manage                        +1624 B  (+6.1%)     +475 B  (+7.2%)
async-load-reader-sidebar                             +699 B  (+1.1%)     +180 B  (+1.2%)
async-load-reader-list-stream                         +699 B  (+5.8%)     +166 B  (+5.0%)
async-load-design-blocks                              +105 B  (+0.0%)      +19 B  (+0.0%)
async-load-components-web-preview-component           +105 B  (+0.0%)      +15 B  (+0.0%)
async-load-blocks-support-article-dialog-dialog       +105 B  (+0.1%)      +15 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jsnmoon jsnmoon added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 11, 2020
@jsnmoon jsnmoon marked this pull request as ready for review June 11, 2020 22:23
@jsnmoon jsnmoon requested a review from a team as a code owner June 11, 2020 22:23
@jsnmoon jsnmoon requested a review from bluefuton June 11, 2020 22:29
@bluefuton
Copy link
Contributor

Form text looks good 馃憤 Can we add translate() for all the labels?

@jsnmoon
Copy link
Member Author

jsnmoon commented Jun 11, 2020

@bluefuton: Added translations to form labels.

The API route currently doesn't respect the is_public flag; I'll work on spinning up a patch.

client/reader/list-manage/index.jsx Outdated Show resolved Hide resolved
client/reader/list-manage/index.jsx Outdated Show resolved Hide resolved
@jsnmoon jsnmoon requested a review from bluefuton June 11, 2020 23:19
@jsnmoon jsnmoon dismissed bluefuton鈥檚 stale review June 11, 2020 23:19

Added translations

@jsnmoon
Copy link
Member Author

jsnmoon commented Jun 11, 2020

The API route currently doesn't respect the is_public flag; I'll work on spinning up a patch.

D44850-code.

@bluefuton
Copy link
Contributor

Great stuff 馃憤 Working well for me (aside from the public flag - I'll check out the patch next!)

How about having the route at /read/list/new instead?

@bluefuton
Copy link
Contributor

One other note that we can address in a different PR - the new list doesn't appear in the sidebar. It is being correctly added to state.reader.lists.items though.

Copy link
Contributor

@bluefuton bluefuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a suggested change of route to /read/list/new, this works well - nice one :shipit:

Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnmoon jsnmoon merged commit 35205ce into master Jun 12, 2020
@jsnmoon jsnmoon deleted the add/create-reader-lists-form branch June 12, 2020 19:58
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 12, 2020
@a8ci18n
Copy link

a8ci18n commented Jun 12, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3821377

Thank you @jsnmoon for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 25, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants