-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy for plans product cards #45035
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~80 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~911 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~370 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
785acad
to
3747538
Compare
@@ -9,6 +9,7 @@ | |||
& > .details__column { | |||
flex-basis: 50%; | |||
flex-grow: 0; | |||
align-self: flex-start; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix layout issue in Details page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one non-blocking comment, otherwise looks great! 🎉
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4246417 Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR includes the final copy for the Jetpack Security, Security Daily, and Security Real-time product cards.
Jetpack Complete was handled in #45009.
Implementation notes
I did some refactoring in
client/my-sites/plans-v2/utils.ts
to handle Jetpack Security that's not a plan, codewise. The diff is hard to read, check the file instead.Note: Missing icons will be added in a separate PR.
Testing instructions
Screenshots
Security
Security options