Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for plans product cards #45035

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Update copy for plans product cards #45035

merged 7 commits into from
Aug 20, 2020

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Aug 19, 2020

Changes proposed in this Pull Request

This PR includes the final copy for the Jetpack Security, Security Daily, and Security Real-time product cards.

Jetpack Complete was handled in #45009.

Implementation notes

I did some refactoring in client/my-sites/plans-v2/utils.ts to handle Jetpack Security that's not a plan, codewise. The diff is hard to read, check the file instead.

Note: Missing icons will be added in a separate PR.

Testing instructions

  • Visit the Plans page with the offer reset flow enabled
  • Check the copy of the Jetpack Security product card against the copydeck
  • Don't forget to check the descriptions and links in the tooltips
  • Click on "Get Jetpack Security"
  • Check the copy of the Security Daily and Real-time cards against the copydeck

Screenshots

Security
Screen Shot 2020-08-19 at 2 47 18 PM

Security options
Screen Shot 2020-08-19 at 2 47 02 PM

@matticbot
Copy link
Contributor

@monsieur-z monsieur-z added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. labels Aug 19, 2020
@matticbot
Copy link
Contributor

matticbot commented Aug 19, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~80 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +453 B  (+0.0%)      +80 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~911 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
purchases            +2513 B  (+0.2%)     +234 B  (+0.1%)
plans                +2513 B  (+0.4%)     +255 B  (+0.2%)
jetpack-connect      +2513 B  (+0.3%)     +255 B  (+0.1%)
checkout             +2234 B  (+0.1%)     +167 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~370 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-signup-steps-plans-atomic-store      +2234 B  (+1.7%)     +146 B  (+0.4%)
async-load-signup-steps-plans                   +2234 B  (+1.2%)     +150 B  (+0.3%)
async-load-blocks-inline-help                    +453 B  (+0.3%)      +74 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -9,6 +9,7 @@
& > .details__column {
flex-basis: 50%;
flex-grow: 0;
align-self: flex-start;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix layout issue in Details page.

@monsieur-z monsieur-z marked this pull request as ready for review August 19, 2020 18:59
@monsieur-z monsieur-z requested a review from a team August 19, 2020 18:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 19, 2020
Copy link
Contributor

@ChaosExAnima ChaosExAnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one non-blocking comment, otherwise looks great! 🎉

client/my-sites/plans-v2/utils.ts Outdated Show resolved Hide resolved
@monsieur-z monsieur-z merged commit 02cd405 into master Aug 20, 2020
@monsieur-z monsieur-z deleted the update/plan-card-copy branch August 20, 2020 13:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2020
@a8ci18n
Copy link

a8ci18n commented Aug 20, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4246417

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 31, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants