Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pricing page i5: update copy #47389

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Pricing page i5: update copy #47389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5d309a
Pricing page i5: rename products
monsieur-z Nov 12, 2020
c57071f
Pricing page i5: rename Site Search card call-to-action
monsieur-z Nov 12, 2020
ab94eef
Pricing page i5: update Jetpack cloud masthead copy
monsieur-z Nov 12, 2020
e77caba
Pricing page i5: update copy for plan cards
monsieur-z Nov 12, 2020
724d3fa
Pricing page i5: update product cards copy
monsieur-z Nov 12, 2020
40f5fa5
Pricing page i5: update Scan description
monsieur-z Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/lib/plans/plans-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,10 @@ const getPlanJetpackSecurityRealtimeDetails = () => ( {
const getPlanJetpackCompleteDetails = () => ( {
group: constants.GROUP_JETPACK,
type: constants.TYPE_ALL,
getTitle: () => translate( 'Jetpack Complete' ),
getTitle: () =>
getJetpackCROActiveVersion() === 'i5'
? translate( 'Complete' )
: translate( 'Jetpack Complete' ),
getAudience: () => translate(),
availableFor: ( plan ) =>
[
Expand Down
14 changes: 11 additions & 3 deletions client/lib/products-values/translations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,17 @@ export const getJetpackProductsDisplayNames = () => {
</>
);
const search =
currentCROvariant === 'v2' ? translate( 'Jetpack Site Search' ) : translate( 'Jetpack Search' );
const scan = translate( 'Jetpack Scan' );
const antiSpam = <>{ translate( 'Jetpack Anti-spam' ) }</>;
{
v2: translate( 'Jetpack Site Search' ),
i5: translate( 'Site Search' ),
}[ currentCROvariant ] || translate( 'Jetpack Search' );
const scan = currentCROvariant === 'i5' ? translate( 'Scan' ) : translate( 'Jetpack Scan' );
const antiSpam =
currentCROvariant === 'i5' ? (
translate( 'Anti-spam' )
) : (
<>{ translate( 'Jetpack Anti-spam' ) }</>
);

return {
[ CONSTANTS.PRODUCT_JETPACK_BACKUP_DAILY ]: backupDaily,
Expand Down
28 changes: 16 additions & 12 deletions client/my-sites/plans-v2/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,19 +301,23 @@ export const EXTERNAL_PRODUCT_CRM: SelectorProduct = {
? 'jetpack_crm_dark'
: 'jetpack_crm',
displayName:
getJetpackCROActiveVersion() === 'v2'
? translate( 'Jetpack CRM {{em}}Entrepreneur{{/em}}', {
components: {
em: createElement( 'em' ),
},
} )
: translate( 'Jetpack CRM' ),
{
v2: translate( 'Jetpack CRM {{em}}Entrepreneur{{/em}}', {
components: {
em: createElement( 'em' ),
},
} ),
i5: translate( 'CRM Entrepreneur' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'CRM: Entrepreneur bundle' ) ES Score: 10
See 1 additional suggestions in the PR translation status page

}[ getJetpackCROActiveVersion() ] || translate( 'Jetpack CRM' ),

shortName:
getJetpackCROActiveVersion() === 'v2'
? translate( 'Jetpack CRM ' )
: translate( 'CRM', {
comment: 'Short name of the Jetpack CRM',
} ),
{
v2: translate( 'Jetpack CRM ' ),
i5: translate( 'CRM Entrepreneur' ),
}[ getJetpackCROActiveVersion() ] ||
translate( 'CRM', {
comment: 'Short name of the Jetpack CRM',
} ),
tagline: translate( 'Manage contacts effortlessly' ),
// Jetpack CRM isn't considered as a product like others for the time being (and therefore not
// available via the API). Rather like a third-party product.
Expand Down