New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Display warning before Atomic revert #56399
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-15280 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1066 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
5ef7b2e
to
c7b8c07
Compare
cf49b91
to
5fdcd49
Compare
5fdcd49
to
33fa7bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @dsas can you have a look before we merge it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me 👍 . The site is marked as free but the menu stays as 'Business', but I think that's a separate known issue.
Nitpicky and unlikely to matter but the wording on the warning screen says "....continue with plan deactivation" which isn't exactly consistent with the wording elsewhere where we talk about removing plans not deactivating them.
I thought it'd be nice if the wording was a bit more reassuring to say something about the content being kept, but I guess if the content is dependant upon a plugin it won't be, so not saying anything about it (as is implemented) is safer.
Yeah, that's unrelated to this; it's a caching issue in Jetpack. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6647951 Thank you @mmtr for including a screenshot in the description! This is really helpful for our translators. |
1 similar comment
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6647951 Thank you @mmtr for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Fixes #55239.
Fixes #55240.
Changes proposed in this Pull Request
Displays a warning prior cancelling a plan from an Atomic site informing that all third party plugins/themes and their content will be removed. It also provides a link to download a backup.
Testing instructions
?flags=atomic/automated-revert
at the end of the URL.atomic_subscription_revert_after_lossless_import
async job (see testing instructions in D66763-code).