Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Display warning before Atomic revert #56399

Merged
merged 3 commits into from Sep 23, 2021

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Sep 20, 2021

Fixes #55239.
Fixes #55240.

Changes proposed in this Pull Request

Displays a warning prior cancelling a plan from an Atomic site informing that all third party plugins/themes and their content will be removed. It also provides a link to download a backup.

Screen Shot 2021-09-21 at 12 45 00

Testing instructions

  • Use the Calypso live link below and append ?flags=atomic/automated-revert at the end of the URL.
  • Go to Upgrades > Purchases.
  • Select the site plan.
  • Go through the removal/cancellation flow.
  • Make sure you get the feedback form as first step.
  • Make sure that "Step 1 of 2" is displayed in the header.
  • Make sure you can go to the next step after filling the form.
  • Make sure you get the proceed with caution form as second step.
    • Make sure that "Step 2 of 2" is displayed in the header.
  • Make sure the link to the backup works correctly.
  • Make sure you are required to tick all the checkboxes before being submitting the form.
  • Submit the form.
  • Make sure you get a success notification indicating the removal/cancellation has been queued.
  • Manually run the atomic_subscription_revert_after_lossless_import async job (see testing instructions in D66763-code).
  • Reload Calypso.
  • Make sure the Atomic site is on a Free plan now.

@mmtr mmtr added [Status] In Progress [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Atomic [Feature] Backups The Jetpack Backup product labels Sep 20, 2021
@mmtr mmtr self-assigned this Sep 20, 2021
@github-actions
Copy link

github-actions bot commented Sep 20, 2021

@matticbot
Copy link
Contributor

matticbot commented Sep 20, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1066 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases      +4294 B  (+0.3%)    +1066 B  (+0.3%)
purchases           +4294 B  (+0.3%)    +1066 B  (+0.3%)
domains             +4294 B  (+0.3%)    +1066 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mmtr mmtr force-pushed the add/plan-cancel-atomic-revert-warning branch 2 times, most recently from 5ef7b2e to c7b8c07 Compare September 21, 2021 10:28
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Sep 21, 2021
@mmtr mmtr force-pushed the add/plan-cancel-atomic-revert-warning branch 2 times, most recently from cf49b91 to 5fdcd49 Compare September 21, 2021 11:38
Base automatically changed from add/atomic-self-revert to trunk September 21, 2021 15:05
@mmtr mmtr requested review from a team as code owners September 21, 2021 15:05
@mmtr mmtr force-pushed the add/plan-cancel-atomic-revert-warning branch from 5fdcd49 to 33fa7bc Compare September 21, 2021 15:07
@mmtr mmtr removed request for a team September 21, 2021 15:07
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @dsas can you have a look before we merge it?

Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me 👍 . The site is marked as free but the menu stays as 'Business', but I think that's a separate known issue.

Nitpicky and unlikely to matter but the wording on the warning screen says "....continue with plan deactivation" which isn't exactly consistent with the wording elsewhere where we talk about removing plans not deactivating them.

I thought it'd be nice if the wording was a bit more reassuring to say something about the content being kept, but I guess if the content is dependant upon a plugin it won't be, so not saying anything about it (as is implemented) is safer.

@BogdanUngureanu
Copy link
Contributor

Works well for me 👍 . The site is marked as free but the menu stays as 'Business', but I think that's a separate known issue.

Yeah, that's unrelated to this; it's a caching issue in Jetpack.

@BogdanUngureanu BogdanUngureanu merged commit af5e836 into trunk Sep 23, 2021
@BogdanUngureanu BogdanUngureanu deleted the add/plan-cancel-atomic-revert-warning branch September 23, 2021 14:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 23, 2021
@a8ci18n
Copy link

a8ci18n commented Sep 23, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6647951

Thank you @mmtr for including a screenshot in the description! This is really helpful for our translators.

1 similar comment
@a8ci18n
Copy link

a8ci18n commented Oct 1, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6647951

Thank you @mmtr for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 21, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atomic Downgrade: Allow users to download a backup before revert Atomic Downgrade: Display revert warning
5 participants