Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Replace external link with clickable span #63886

Merged
merged 2 commits into from May 24, 2022

Conversation

lsl
Copy link
Contributor

@lsl lsl commented May 23, 2022

This isn't a great fix but it gets rid of the console warning.

@SaxonF the card underneath this link is still clickable (we're nesting link <a /> tags in html and its giving a react error), should we just replace the whole card's link to the support doc or should we implement some kind of full overlay? At the moment we're rendering the link in the middle of the card to make space for it, imo we should do something different maybe make the card not clickable and only have the middle link or move the card link to the card title and have two.

Changes proposed in this Pull Request

  • Replace ExternalLink with clickable span

Testing instructions

Fixes #63586

@lsl lsl self-assigned this May 23, 2022
@matticbot
Copy link
Contributor

matticbot commented May 23, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
plugins           +109 B  (+0.0%)      +24 B  (+0.0%)
marketplace       +109 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. Good job @lsl!

@paulopmt1 paulopmt1 merged commit 0b53b75 into trunk May 24, 2022
@paulopmt1 paulopmt1 deleted the update/mp-link-nesting branch May 24, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketplace: Nested <a/> error
3 participants