Marketplace: Replace external link with clickable span #63886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a great fix but it gets rid of the console warning.
@SaxonF the card underneath this link is still clickable (we're nesting link
<a />
tags in html and its giving a react error), should we just replace the whole card's link to the support doc or should we implement some kind of full overlay? At the moment we're rendering the link in the middle of the card to make space for it, imo we should do something different maybe make the card not clickable and only have the middle link or move the card link to the card title and have two.Changes proposed in this Pull Request
Testing instructions
<a />
warnings in the console.Fixes #63586