Reading Settings: Update the label/description on the "Welcome email text" and "Comment follow email text" settings

[ivan-ottinger]

This PR updates labels and description on several form fields on the new Reading settings page.

Proposed Changes

• Change Welcome email text form field label to Confirmation email message.
• Change The welcome message sent out to new readers when they subscribe to your blog. form field explanation to The confirmation message sent out to new readers when they subscribe to your blog..
• Change Comment follow email text form field label to Comment follow email message.
• Fix a minor typo in the CSS class name: site-settings__emails-test-settings-container → site-settings__emails-text-settings-container.

Before	After

Fixes #72485.

Related discussion: pdtkmj-Vc-p2#comment-1886

Testing Instructions

1. Check out the PR and build it locally.
2. Make sure the WPCOM locale is set to English at http://calypso.localhost:3000/me/account.
3. Navigate to the new Reading settings page at http://calypso.localhost:3000/settings/reading/[site-address].
4. Review the updated labels and field description - they should match the "After" screenshot.
5. Change your WPCOM locale to non-English language.
6. Review the updated labels and field description again - this time, the old already-translated strings should be used.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-28f2c391f94466dc3131c3c7a4bc7cd59c5a5bc0

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-28f2c391f94466dc3131c3c7a4bc7cd59c5a5bc0&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~65 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
settings-reading       +444 B  (+0.2%)      +65 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[yansern]

It has language fallbacks in case translation is not ready. LGTM.

I'd imagine if Reading Settings had E2E tests, changing the name / id for the form input would've required changing it on the accompanying tests. But all is good here.

[ivan-ottinger]

Thank you for the review, Yan! 🙂

I'd imagine if Reading Settings had E2E tests, changing the name / id for the form input would've required changing it on the accompanying tests. But all is good here.

Yes, we haven't introduced new E2E tests here.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7800317

Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.