Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n comment for Gravatar's signup and login pages #76860

Merged

Conversation

wellyshen
Copy link
Contributor

Related to 105164-gh-Automattic/gravatar

Proposed Changes

  • To add an i18n comment
  • To replace the siteName with clientTitle for the purpose of code consistent

Testing Instructions

  • Switch to the branch and run it locally (check the doc to setup your dev environment)
  • Log out of your WP account
  • Go to the log-in page by this URL (you might need to modify your origin), and the footer still works the same.
login
  • Go to the sign-up page by this URL (you might need to modify your origin), and the footer still works the same.
signup

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@wellyshen wellyshen self-assigned this May 12, 2023
@wellyshen wellyshen added Login [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels May 12, 2023
@wellyshen wellyshen marked this pull request as ready for review May 12, 2023 03:05
@matticbot
Copy link
Contributor

matticbot commented May 12, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~60 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +147 B  (+0.0%)      +60 B  (+0.0%)
entry-main          +147 B  (+0.0%)      +60 B  (+0.0%)
entry-login         +147 B  (+0.0%)      +60 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@wellyshen wellyshen requested review from a team and johngodley May 12, 2023 03:09
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 12, 2023
@wellyshen wellyshen removed the request for review from johngodley May 12, 2023 03:09
@unDemian unDemian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
@wellyshen wellyshen merged commit 089ae1b into trunk May 12, 2023
20 checks passed
@wellyshen wellyshen deleted the chore/add-i18n-comments-for-gravatar-signup-login-pages branch May 12, 2023 08:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2023
@a8ci18n
Copy link

a8ci18n commented May 12, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7983279

Thank you @wellyshen for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 28, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants