Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting Command Palette: Simplify animation logic for Safari #86457

Merged

Conversation

sejas
Copy link
Member

@sejas sejas commented Jan 16, 2024

Proposed Changes

  • Improve the banner animation on Safari

Testing Instructions

  • Navigate to /sites on your desktop using Safari, Chrome and Firefox
  • Observe the banner animation works as expected.

Screencasts

Safari

hcp-banner-safari-animation.mp4

Chrome

hcp-banner-chrome-animation.mp4

Firefox

hcp-banner-firefox-animation.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@sejas sejas self-assigned this Jan 16, 2024
@sejas sejas added Sites Management Page Calypso page with route `/sites` Hosting Command Palette labels Jan 16, 2024
@sejas sejas requested review from javierarce and a team January 16, 2024 11:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~17 bytes removed 📉 [gzipped])

name                     parsed_size           gzip_size
sites-dashboard                -38 B  (-0.0%)       -9 B  (-0.0%)
import-hosted-site-flow        -38 B  (-0.0%)       -8 B  (-0.0%)
import-flow                    -38 B  (-0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hosting-command-palette-improve-banner-safari-animation on your sandbox.

Copy link

@javierarce javierarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screen.Recording.2024-01-16.at.12.22.45.mov

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on Safari on my end and it looks great. Nice work adjusting the opacity values within keyframes!

@sejas sejas merged commit 5295696 into trunk Jan 16, 2024
15 of 16 checks passed
@sejas sejas deleted the update/hosting-command-palette-improve-banner-safari-animation branch January 16, 2024 14:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2024
TimBroddin pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hosting Command Palette Sites Management Page Calypso page with route `/sites`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants