New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting Command Palette: Simplify animation logic for Safari #86457
Hosting Command Palette: Simplify animation logic for Safari #86457
Conversation
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~17 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Screen.Recording.2024-01-16.at.12.22.45.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on Safari on my end and it looks great. Nice work adjusting the opacity values within keyframes!
Improve the banner animation on Safari
Proposed Changes
Testing Instructions
/siteson your desktop using Safari, Chrome and FirefoxScreencasts
Safari
hcp-banner-safari-animation.mp4
Chrome
hcp-banner-chrome-animation.mp4
Firefox
hcp-banner-firefox-animation.mp4
Pre-merge Checklist