Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Handle TypeScript #604

Merged
merged 2 commits into from May 28, 2019
Merged

Build: Handle TypeScript #604

merged 2 commits into from May 28, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 28, 2019

Description:

After getting blocked in #599, this is a "minimal" PR to get TypeScript working.

Housekeeping:

  • Target "live" electron version via @babel/env
  • Remove pug dependency which is never used.
  • Add prettier

Motivation and Context:

We're using TypeScript in Calypso, but that breaks desktop.

How Has This Been Tested:

I can't get the dev app running locally:

ENOENT: no such file or directory, open '…/wp-desktop/dev-app-update.yml'

I rebased on this branch the test branch for a Calypso PR (Automattic/wp-calypso#32926) that was failing due to missing TypeScript support. It passes 🎉.

Closes #599

@blowery
Copy link
Contributor

blowery commented May 28, 2019

@sirreal I seem to have the following in a local dev-app-update.yml:

owner: Automattic
repo: wp-desktop
provider: github

Trying creating that and let me know how it goes?

Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirreal, I verified that this works with make dev-server and make dev on my local install.

@sirreal sirreal merged commit 1d7b459 into develop May 28, 2019
@sirreal sirreal deleted the update/fix-typescript branch May 28, 2019 15:19
blowery pushed a commit that referenced this pull request Jun 10, 2019
* Fix all the things for TypeScript

* Add prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants