New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching in customize preview #161

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
3 participants
@westonruter
Contributor

westonruter commented Dec 8, 2016

This is a first stab at ensuring compatibility with the customizer.

A bug report for 4.7 seems to indicate it is not compatible: https://core.trac.wordpress.org/ticket/39128

I'm trying to pin down where the problem lies exactly, but here's an initial stab at compatibility.

@kraftbj

This comment has been minimized.

Show comment
Hide comment
@kraftbj

kraftbj Dec 9, 2016

Contributor

@westonruter Thanks and this makes sense. Good to merge or do you think we should try to pin down things firmly first?

Contributor

kraftbj commented Dec 9, 2016

@westonruter Thanks and this makes sense. Good to merge or do you think we should try to pin down things firmly first?

@kraftbj kraftbj added this to the 1.4.9 milestone Dec 9, 2016

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Dec 9, 2016

Contributor

It does fix the one issue that I observed where changes failed to get applied in the preview after a refresh, so in that sense yes.

I've asked sixsigmablackbelt for more details on their configuration to figure out how to exactly reproduce the originally-reported issue.

Contributor

westonruter commented Dec 9, 2016

It does fix the one issue that I observed where changes failed to get applied in the preview after a refresh, so in that sense yes.

I've asked sixsigmablackbelt for more details on their configuration to figure out how to exactly reproduce the originally-reported issue.

@westonruter

This comment has been minimized.

Show comment
Hide comment
Contributor

westonruter commented Jan 23, 2017

@donnchawp

This comment has been minimized.

Show comment
Hide comment
@donnchawp

donnchawp Feb 3, 2017

Contributor

I can't replicate this problem at all. I'm using a multisite and domain mapping and customizer works ok but the fix above looks harmless so I'm happy to merge this.

Contributor

donnchawp commented Feb 3, 2017

I can't replicate this problem at all. I'm using a multisite and domain mapping and customizer works ok but the fix above looks harmless so I'm happy to merge this.

@donnchawp donnchawp merged commit 0a7bab6 into Automattic:master Feb 3, 2017

kraftbj pushed a commit that referenced this pull request Feb 9, 2017

kraftbj pushed a commit that referenced this pull request Feb 9, 2017

donncha
* Github merge:
* Make sure $cache_path has a trailing slash (#77)
* Remove flush() (#127) but also check if headers are empty and flush and get headers again. (#179)
* Add fix for customizer (#161) and don't cache PUT AND DELETE requests (#178)
* Check for superglobals before using them. (#131)



git-svn-id: http://plugins.svn.wordpress.org/wp-super-cache/trunk@1588365 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment