New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply realpath to $cache_path to avoid problems on Windows #188

Merged
merged 3 commits into from Feb 7, 2017

Conversation

Projects
None yet
2 participants
@donnchawp
Copy link
Contributor

donnchawp commented Feb 6, 2017

Fixes #183.
realpath() on Windows will change a UNIX style path to a Windows C:
type path.

Apply realpath to $cache_path to avoid problems on Windows
Fixes #183.
realpath() on Windows will change a UNIX style path to a Windows C:\
type path.

@donnchawp donnchawp self-assigned this Feb 6, 2017

@DrLightman

This comment has been minimized.

Copy link

DrLightman commented on 8679842 Feb 6, 2017

donncha there is a typo here:

if ( substr( $dir, 0, strlen( $rpcache_path ) ) != $rp_cache_path )

you missed an underscore in $rpcache_path

@donnchawp

This comment has been minimized.

Copy link
Contributor

donnchawp commented Feb 6, 2017

Thank you for spotting that!

@donnchawp donnchawp merged commit a5c7c2d into master Feb 7, 2017

@donnchawp donnchawp deleted the 183_realpath_fix_for_windows branch Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment