Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings page cache on/off process. #255

Merged
merged 9 commits into from Jun 9, 2017
Merged

Conversation

@donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Jun 7, 2017

See #224.

Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.

Simple = PHP
Expert = mod_rewrite

And no mention of legacy caching which has become "standard caching".

Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.

Simple = PHP
Expert = mod_rewrite

And no mention of legacy caching which has become "standard caching".
@donnchawp donnchawp self-assigned this Jun 7, 2017
@donnchawp
Copy link
Contributor Author

@donnchawp donnchawp commented Jun 7, 2017

Looks something like this (currently):

screen shot 2017-06-07 at 17 35 25

@donnchawp
Copy link
Contributor Author

@donnchawp donnchawp commented Jun 8, 2017

A weakness of this UI is that "Standard Caching" has to be enabled for "Super Caching" to be enabled. The control for both maybe should be one element. Maybe radio boxes?

  1. Standard Caching
  2. Super Caching (includes Standard Caching)
@donnchawp
Copy link
Contributor Author

@donnchawp donnchawp commented Jun 8, 2017

After the last code check in:

screen shot 2017-06-08 at 13 17 58

Add "DISABLE_SUPERCACHE" constant that disables supercache caching.
The on/off switch enables wp-cache and supercache caching by default.
@donnchawp
Copy link
Contributor Author

@donnchawp donnchawp commented Jun 8, 2017

And now it's even simpler:

screen shot 2017-06-08 at 16 58 29

@donnchawp donnchawp merged commit 5fda1e6 into master Jun 9, 2017
@donnchawp donnchawp deleted the settings_page_cache_types branch Jun 9, 2017
ockham added a commit to Automattic/wp-calypso that referenced this pull request Jun 26, 2017
Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string.
To align with Automattic/wp-super-cache#255
ockham added a commit to Automattic/wp-calypso that referenced this pull request Jun 27, 2017
Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string.
To align with Automattic/wp-super-cache#255
ockham added a commit to Automattic/wp-calypso that referenced this pull request Jun 28, 2017
* WPSC: Simplify Caching UI

Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string.
To align with Automattic/wp-super-cache#255

* WPSC: If cache_type is 'wpcache', fall back to 'Simple' mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant