Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate settings page cache on/off process. #255
Conversation
donnchawp
self-assigned this
Jun 7, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks something like this (currently):
|
This comment has been minimized.
This comment has been minimized.
|
A weakness of this UI is that "Standard Caching" has to be enabled for "Super Caching" to be enabled. The control for both maybe should be one element. Maybe radio boxes?
|
This comment has been minimized.
This comment has been minimized.
|
After the last code check in:
|
This comment has been minimized.
This comment has been minimized.
|
And now it's even simpler:
|
donnchawp
added some commits
Jun 8, 2017
donnchawp
merged commit 5fda1e6
into
master
Jun 9, 2017
donnchawp
deleted the
settings_page_cache_types
branch
Jun 9, 2017
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 26, 2017
ockham
referenced this pull request
Jun 26, 2017
Merged
Extensions: WPSC: Simplify Caching UI #15490
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 27, 2017
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
donnchawp commentedJun 7, 2017
See #224.
Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.
Simple = PHP
Expert = mod_rewrite
And no mention of legacy caching which has become "standard caching".