Update settings page cache on/off process. #255
Merged
Conversation
Legacy caching wasn't a great name for the "default caching" this plugin does, and only technical people will recognise PHP and mod_rewrite so we simplified it. Simple = PHP Expert = mod_rewrite And no mention of legacy caching which has become "standard caching".
|
Looks something like this (currently):
|
|
A weakness of this UI is that "Standard Caching" has to be enabled for "Super Caching" to be enabled. The control for both maybe should be one element. Maybe radio boxes?
|
|
After the last code check in:
|
Add "DISABLE_SUPERCACHE" constant that disables supercache caching. The on/off switch enables wp-cache and supercache caching by default.
|
And now it's even simpler:
|
ockham
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 26, 2017
Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string. To align with Automattic/wp-super-cache#255
ockham
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 27, 2017
Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string. To align with Automattic/wp-super-cache#255
ockham
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jun 28, 2017
* WPSC: Simplify Caching UI Rename PHP Caching option to "Simple" and mod_rewrite one to "Expert"; drop legacy caching option; update explanation string. To align with Automattic/wp-super-cache#255 * WPSC: If cache_type is 'wpcache', fall back to 'Simple' mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
See #224.
Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.
Simple = PHP
Expert = mod_rewrite
And no mention of legacy caching which has become "standard caching".