Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pre-loading, start with the newest post as the documentation says #55

Merged
merged 1 commit into from Feb 8, 2017

Conversation

@leewillis77
Copy link
Contributor

@leewillis77 leewillis77 commented Jul 30, 2015

The help content on the Preloading page states:

"Preloading creates lots of files however. Caching is done from the newest post to the oldest so please consider only caching the newest if you have lots (10,000+) of posts. This is especially important on shared hosting."

This seems a good approach, however currently the code picks post "oldest" first, not "newest". This PR amends things to pick the "newest" posts to preload first.

* The current definition of "newest" or "oldest" is actually based on post ID, and this PR maintains that, albeit swapping the ordering. However ordering by post_modified might actually be better - happy to revise this PR if you agree.

@donnchawp donnchawp merged commit 4fd5602 into Automattic:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants