Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check the cache max time if it's not 0, and GC disabled. #571

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
1 participant
@donnchawp
Copy link
Contributor

donnchawp commented Jul 20, 2018

By setting the cache max time to 0 garbage collection is disabled but
this test would stop PHP serving cache files because it detected that
they were expired.
Fixes https://wordpress.org/support/topic/version-1-6-2-fails-to-cache-had-to-revert-to-1-6-1/

Only check the cache max time if it's not 0, and GC disabled.
By setting the cache max time to 0 garbage collection is disabled but
this test would stop PHP serving cache files because it detected that
they were expired.
Fixes
https://wordpress.org/support/topic/version-1-6-2-fails-to-cache-had-to-revert-to-1-6-1/

@donnchawp donnchawp self-assigned this Jul 20, 2018

@donnchawp donnchawp merged commit b19a493 into master Jul 20, 2018

@donnchawp donnchawp deleted the fix_gc_disabled branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.