Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves delete cache in admin bar #578

Merged

Conversation

@stodorovic
Copy link
Contributor

@stodorovic stodorovic commented Aug 7, 2018

  • PHPCS fixes in function admin_bar_delete_page.
  • Better logic for checking (uses wp_get_referer, doesn't return if realpath is false, ... )

Fixes #558.

@donnchawp donnchawp merged commit 9e3a4fc into Automattic:master Aug 7, 2018
@stodorovic stodorovic deleted the stodorovic:fix-delete-page-in-admin-bar branch Aug 7, 2018
@eurobank
Copy link

@eurobank eurobank commented Aug 20, 2018

This doesn't seem to work. Same as before.

@stodorovic
Copy link
Contributor Author

@stodorovic stodorovic commented Aug 20, 2018

Hi @eurobank

This PR is little cleanup and it fixes redirect issue. I've found more issues and I've created #589. I'm still testing it and it could be great if you want to test #589 (you can download my branch fixes-admin-bar-render or only file wp-cache.php from there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants