New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video timestamp is now saved on reception, same as with navdata; also fi... #89

Closed
wants to merge 1 commit into
base: catkin
from

Conversation

Projects
None yet
2 participants
@v01d
Contributor

v01d commented Feb 7, 2014

I've found at by looking at the code of the driver (and while looking into timing issues in the reception of messages in my code) that, in contrast to how navdata is published (where there is a navdata_reception_time in the receiver thread), the video thread in video.cpp does not store the reception time.
I've made this simple modification which should improve timestamp precision a bit.

On the other hand, it seems that the cinfo stamps were not matched against the image stamp in drone v1. I've made this modification also (lines 392-394).

One question: why is the video buffer copied (for both drone versions) before the if that checks which camera needs to be copied? In case the selected camera is the vertical one (for example), to me it looks like there will be two copies of the video buffer (were the second overrides the first).

v01d
video timestamp is now saved on reception, same as with navdata; also…
… fixed missing cinfo stamp update for dronev1
@mani-monaj

This comment has been minimized.

Show comment
Hide comment
@mani-monaj

mani-monaj Feb 19, 2014

Member

Thank you Matias. The video receiving thread needs some re-factoring and optimization. I will apply your proposed changes during the re-factoring process.

Member

mani-monaj commented Feb 19, 2014

Thank you Matias. The video receiving thread needs some re-factoring and optimization. I will apply your proposed changes during the re-factoring process.

@mani-monaj mani-monaj added this to the 1.4 milestone Jun 23, 2014

@v01d v01d deleted the v01d:video_timestamp branch Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment