New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonoMac-based backend #1005

Merged
merged 16 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants

@kekekeks kekekeks changed the title from WIP: MonoMac-based backend to MonoMac-based backend Sep 8, 2017

@kekekeks kekekeks requested review from grokys and jkoritzinsky Sep 8, 2017

@grokys

I can't review as I don't have a mac, but it's going to be a great thing to have!

@jkoritzinsky

Looks good! I'm not near my Mac so I'll have to wait till the start of the week to test this out. I have a few comments, but other than those everything looks pretty good.

public void RunLoop(CancellationToken cancellationToken)
{
NSApplication.SharedApplication.ActivateIgnoringOtherApps(true);
//NSApplication.SharedApplication.Run();

This comment has been minimized.

@jkoritzinsky

jkoritzinsky Sep 8, 2017

Member

Nit: Commented out code.

public void ShowTaskbarIcon(bool value)
{
//No-OP, there is no such this as taskbar in OSX

This comment has been minimized.

@jkoritzinsky

jkoritzinsky Sep 8, 2017

Member

I was thinking this would map over as turning on and off having an icon visible in the Dock since that would make the most sense.

This comment has been minimized.

@kekekeks

kekekeks Sep 9, 2017

Member

The Dock icon isn't tied to a particular window, it's application-global. OSX will show it even if there are no windows.

It's controlled by NSApplicationActivationPolicy

@AvaloniaUI AvaloniaUI deleted a comment from codecov bot Sep 8, 2017

@codecov

This comment has been minimized.

codecov bot commented Sep 12, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@ec9af9c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1005   +/-   ##
=========================================
  Coverage          ?   43.41%           
=========================================
  Files             ?      542           
  Lines             ?    20718           
  Branches          ?     3018           
=========================================
  Hits              ?     8994           
  Misses            ?    10877           
  Partials          ?      847

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9af9c...7cfe495. Read the comment docs.

@codecov

This comment has been minimized.

codecov bot commented Sep 12, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@64c5a50). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1005   +/-   ##
=========================================
  Coverage          ?   43.41%           
=========================================
  Files             ?      542           
  Lines             ?    20718           
  Branches          ?     3018           
=========================================
  Hits              ?     8994           
  Misses            ?    10877           
  Partials          ?      847

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c5a50...b909380. Read the comment docs.

@kekekeks kekekeks merged commit 5a752f0 into master Sep 13, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@grokys grokys added this to the Beta 1 milestone Jan 26, 2018

@jkoritzinsky jkoritzinsky deleted the monomac branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment