Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow LINQ Expressions for Binding Expressions #1667
If the pull request fixes issue(s) list them like this:
Hey @jkoritzinsky I really love this! It's something I intended to do from the beginning but never got round to.
Just a few things:
- Indexers don't seem to be working. We should really be testing expressions in the unit tests to catch stuff like this
- Should we also allow
Bindingto be created with expressions?
Bindingprovides a few extra features like binding to the
DataContextor to other controls that could be really useful along with strong typing. This could be a separate PR though.
Mainly a few nits here, but I do wonder about my point 2 above: by making
ExpressionObserver only handle expressions and pushing string expressions into
Binding, we're making
ExpressionNode part of the public API when it feels like an implementation detail.
What would be the cons of making
ExpressionObserver handle strings as well?
I have a few reasons why I like having the string support outside of