Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 backend #2011

Merged
merged 55 commits into from Jan 17, 2019

Conversation

Projects
None yet
4 participants
@kekekeks
Copy link
Member

kekekeks commented Oct 24, 2018

This will only require libX11, so we won't depend on locally-installed GTK version.
It will also remove native-to-managed callbacks which make us swallow exceptions in GTK backend right now.

Limitation: File dialogs currently still depend on GTK running on a separate thread. Will be fixed by #2016

CheckTimerTicking();

}

This comment has been minimized.

Copy link
@RoadTrain

RoadTrain Nov 13, 2018

Probably unintended empty lines. I know it's WIP so no offence ;).

public readonly IntPtr TARGETS;
public readonly IntPtr UTF8_STRING;
public readonly IntPtr UTF16_STRING;
public readonly IntPtr ATOM_PAIR;

This comment has been minimized.

Copy link
@RoadTrain

RoadTrain Nov 13, 2018

Mixed up tabs and spaces.

danwalmsley added some commits Dec 4, 2018

@kekekeks

This comment has been minimized.

Copy link
Member Author

kekekeks commented Dec 17, 2018

@danwalmsley Don't bother merging master here, the code still uses the old dialog API. I'll fix it later this month.

@kekekeks kekekeks referenced this pull request Jan 11, 2019

Open

Roadmap #2239

danwalmsley and others added some commits Jan 12, 2019

@kekekeks kekekeks requested a review from wieslawsoltes Jan 14, 2019

kekekeks and others added some commits Jan 16, 2019

@danwalmsley
Copy link
Member

danwalmsley left a comment

LGTM - given this alot of testing on various applications and a few different distros.

@danwalmsley danwalmsley merged commit 0b3a3e1 into AvaloniaUI:master Jan 17, 2019

2 checks passed

Avalonia (Pull Requests) Avalonia (Pull Requests) succeeded
Details
AvaloniaUI.Avalonia #20190117.11 succeeded
Details

@grokys grokys added this to the 0.7.0 milestone Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.